Review TODOs / FIXMEs

[maurolacy]

TODO:

• contracts/tgrade-trusted-circle/src/tests/bdd_tests.rs: // TODO: we need to handle close TRUSTED_CIRCLE here (last voter leaving) (Not needed now. See below in FIXMEs) (Close trusted circle #521)
• contracts/tgrade-trusted-circle/src/tests/unit_tests.rs: // TODO: we should be able to add a custom wasm handler to MockQuerier from cosmwasm_std::mock (Test Improvement)
• contracts/tgrade-trusted-circle/src/msg.rs:// TODO: expose batch query (Small / future improvement)
• contracts/tgrade-tc-payments/src/msg.rs:// TODO: expose batch query (Small / future improvement)
• contracts/tgrade-oc-proposals/src/contract.rs: // TODO: could we instead just reuse the test suite developed for tgrade_valset? (Test improvement)
• contracts/tgrade-oc-proposals/src/msg.rs:// TODO: add some T variants? Maybe good enough as fixed Empty for now (Outdated. Fix/remove TODO)
• contracts/tgrade-ap-voting/src/msg.rs:// TODO: add some T variants? Maybe good enough as fixed Empty for now (Outdated. Fix/remove TODO)

FIXME:

• contracts/tgrade-trusted-circle/src/contract.rs: // FIXME: special check if last member leaving (future story) (Not relevant now) (Close trusted circle #521)
• contracts/tgrade-trusted-circle/src/contract.rs: // FIXME: Use proper SystemError::NoSuchContract on ContractInfo if missing CosmWasm/wasmd#687 (Nice to have. This can be improved in wasmd)
• contracts/tgrade-trusted-circle/src/contract.rs: // FIXME: Currently we don't need mechanism for migrating ballots, as testnets starts from scratch anyway (Migration issue. Not relevant)

[maurolacy]

Before closing this, it would be good to go through those strike through items to implement related changes in the code base.

This is confusing, but strike though in this context was used by me to indicate that those issues were not urgent / required for mainnet launch. It would still be good to go through them one by one, and fix / update what can be fixed / updated there.

[daniellarita]

should we make any follow up tickets or close this?

[maurolacy]

I would leave it as it is. I'll implement the fixes and close this soon.