Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When requesting a website, should check for status code #97

Open
connorjoleary opened this issue Jun 14, 2021 · 0 comments
Open

When requesting a website, should check for status code #97

connorjoleary opened this issue Jun 14, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@connorjoleary
Copy link
Owner

Is your feature request related to a problem? Please describe.
When you parse the results of nested websites the code currently doesn't take into account if the response was something like 404, which means that we may see an error page, but treat is as if the website was returned as expected.

Describe the solution you'd like
When requesting a website, look for a status 200, and if it is something else, don't parse that page.

Describe alternatives you've considered
Give special results for specific codes (404, 403, ...).

Additional context
https://www.reddit.com/r/todayilearned/comments/nz6hl7/til_the_banana_plant_is_a_herb_distantly_related/

@connorjoleary connorjoleary added the good first issue Good for newcomers label Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant