Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify CreateVolumeRequest behavior #289

Closed
saad-ali opened this issue Nov 1, 2018 · 0 comments
Closed

Clarify CreateVolumeRequest behavior #289

saad-ali opened this issue Nov 1, 2018 · 0 comments
Assignees
Milestone

Comments

@saad-ali
Copy link
Member

saad-ali commented Nov 1, 2018

CreateVolumeRequest defines the following on the name field:

    If `CreateVolume` fails, the volume may or may not
    be provisioned. In this case, the CO may call `CreateVolume`
    again, with the same name, to ensure the volume exists.

However, because of "Unable to provision in accessible_topology" or "Unsupported capacity_range" etc. the CO MUST not retry. We should reword this to say

In this case of error, the CO MUST handle the gRPC error codes per the recovery behavior defined in the "CreateVolume Errors" section below.
If `CreateVolume` fails, the volume may or may not be provisioned.
The CO is responsible for cleaning up orphaned volumes. 
Unless otherwise prohibited by "CreateVolume Errors" the CO MAY call `CreateVolume` again, with the same name, to ensure the volume exists or call `DeleteVolume` to ensure it does not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant