Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.4.1 binaries were modified? #1038

Closed
AkihiroSuda opened this issue May 15, 2024 · 3 comments
Closed

v1.4.1 binaries were modified? #1038

AkihiroSuda opened this issue May 15, 2024 · 3 comments

Comments

@AkihiroSuda
Copy link
Contributor

https://github.com/containernetworking/plugins/releases/tag/v1.4.1

The v1.4.1 binaries seems modified without any announcement today.
Was this conducted by a maintainer? Are new binaries trustworthy?
@AkihiroSuda AkihiroSuda mentioned this issue May 15, 2024
Closed
@squeed
Copy link
Member

squeed commented May 15, 2024

Yes, to resolve #1019

Thank you very much for your keen observation!

@AkihiroSuda
Copy link
Contributor Author

Thanks for quick explanation.
Next time could you consider keeping the binaries immutable, and just make a new release?

@spowelljr spowelljr mentioned this issue May 15, 2024
Merged
@apostasie apostasie mentioned this issue May 15, 2024
Merged
This was referenced May 15, 2024
Closed
Merged
@medyagh
Copy link

medyagh commented May 16, 2024

I agree, this broke our ISO build process since the SHAs were changed and it was seens as a not genuine binary

@tgross tgross mentioned this issue May 17, 2024
Closed
@medyagh medyagh mentioned this issue May 17, 2024
Open
@antonipp antonipp mentioned this issue May 21, 2024
Merged
sondavidb added a commit to sondavidb/nerdctl that referenced this issue Jun 19, 2024
@sondavidb
ci: fix cni-plugins-v1.4.1 shasum
20b5b3b 
See containernetworking/plugins#1038

Signed-off-by: David Son <davbson@amazon.com>
@sondavidb sondavidb mentioned this issue Jun 19, 2024
Closed
sondavidb added a commit to sondavidb/nerdctl that referenced this issue Jun 19, 2024
@sondavidb
ci: fix cni-plugins-v1.4.1 shasum
cdf6631 
See containernetworking/plugins#1038

Signed-off-by: David Son <davbson@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@squeed @medyagh @AkihiroSuda