New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the hardcoded dependencies #1051

Open

yashsingh74 wants to merge 1 commit into containernetworking:main from yashsingh74:yashsingh/update-release

+28 −9

yashsingh74 commented May 28, 2024

The PR fixes the following changes-

Allow default run args -it to be overridden by specifying DOCKER_RUN_ARGS.
Introduce GO_IMAGE and GO_VERSION to allow the compiliation docker image to be specified.
Add logic to handle the case where a non alpine golang image is used so that the script no longer blindly attempts to apk install bash and tar. Scripts checks for presence of both commands.
Avoid using dos2unix, use sed


          Updated the hardcoded dependencies

2206c44

Signed-off-by: syash <syash@vmware.com>

yashsingh74 force-pushed the yashsingh/update-release branch from 2169ca8 to 2206c44 Compare

May 28, 2024 10:16

Author

yashsingh74 commented May 28, 2024

cc: @squeed @danwinship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet