Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: configuration files for prod must not use "prod" as infix #55

Open
ThorstenSuckow opened this issue Nov 7, 2021 · 1 comment
Open

refactor: configuration files for prod must not use "prod" as infix #55

ThorstenSuckow opened this issue Nov 7, 2021 · 1 comment
Assignees
@ThorstenSuckow
Labels
enhancement New feature or request

Comments

@ThorstenSuckow
Copy link
Member

The default for config files being queried for production should be the package/application name, postfixed with .conf.json instead of .prod.conf.json. This should be done by explicitly checking for the prod-environment. Each other environment should still use the current env-setting as postfix.
@ThorstenSuckow ThorstenSuckow added the enhancement New feature or request label Nov 7, 2021
@ThorstenSuckow ThorstenSuckow self-assigned this Nov 7, 2021
@ThorstenSuckow
Copy link
Member Author

If we have any meta information available that clearly defines the current environment as "production", this is doable. Ext.manifest should be investigated therefore. Otherwise, a simple check for the key "prod" does not suffice, since this simply an arbitrary value for the env-property in the coon-js-section in the app.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThorstenSuckow ThorstenSuckow

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThorstenSuckow