Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing validation of the configuration file #11

Open
dogukanteber opened this issue Apr 14, 2023 · 2 comments
Open

Missing validation of the configuration file #11

dogukanteber opened this issue Apr 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dogukanteber
Copy link
Collaborator

dogukanteber commented Apr 14, 2023 •
edited
Loading

Currently, we do not validate the configuration file coming from the user. The same goes for server config as well. I am not sure we should implement validation for server config but we should do it for the config file.

For example, when a user does not provide information for admin, we do not open port for /metrics, /ready /pprof/ endpoints and users cannot access those endpoints.
@dogukanteber dogukanteber added the enhancement New feature or request label Apr 14, 2023
@friedrichg
Copy link
Member

For example, when a user does not provide information for admin, we do not open port for /metrics, /ready /pprof/ endpoints and users cannot access those endpoints.

I think these ports should always be available, just use port 80 and 8081 as default ports for them

@dogukanteber
Copy link
Collaborator Author

Okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@friedrichg @dogukanteber