Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix pedantic returns in Pebble #95

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Oct 26, 2023

Removes pedantic returns that are non-idiomatic Go.

Fixes #94

Summary by CodeRabbit

  • Refactor: Simplified the code structure in the PebbleDB component, enhancing the readability and maintainability of the code. This change does not directly impact the user experience but ensures a more robust and efficient system in the long run.

Removes pedantic returns that are non-idiomatic Go.

Fixes cosmos#94
@odeke-em odeke-em requested a review from a team as a code owner October 26, 2023 03:57
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2023

Walkthrough

The changes in this pull request primarily focus on simplifying the code in the PebbleDB struct and its associated methods. The Delete, DeleteSync, and Close methods have been streamlined for improved readability and maintainability.

Changes

File Summary
pebble.go The Delete, DeleteSync, and Close methods of the PebbleDB struct and pebbleDBIterator have been simplified by directly returning the result of the respective operations, enhancing code readability and maintainability.

🐇

In the land of code, less is often more,

Simplified methods, complexity we abhor.

With each pull request, we strive,

To keep our codebase agile and alive. 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 81c032d and bdc1b1a.
Files selected for processing (1)
  • pebble.go (3 hunks)
Files skipped from review due to trivial changes (1)
  • pebble.go

@tac0turtle tac0turtle enabled auto-merge (squash) October 26, 2023 07:24
@tac0turtle tac0turtle merged commit 8a5e4f5 into cosmos:main Oct 26, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants