Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defer close should be used after error check #1259

Closed
QiAnXinCodeSafe opened this issue Jun 14, 2018 · 2 comments
Closed

defer close should be used after error check #1259

QiAnXinCodeSafe opened this issue Jun 14, 2018 · 2 comments
Assignees
@ValarDragon
Labels
T:Bug

Comments

@QiAnXinCodeSafe
Copy link

cosmos-sdk/server/test_helpers.go

Line 21 in 0866494

defer l.Close()

@ValarDragon ValarDragon self-assigned this Jun 16, 2018
@ValarDragon ValarDragon mentioned this issue Jun 16, 2018
Merged
6 tasks
@ValarDragon
Copy link
Contributor

Thanks for reporting this! Its been addressed in my PR, along with all other similar instances!

@cwgoes
Copy link
Contributor

cwgoes commented Jun 16, 2018

Merged.

@cwgoes cwgoes closed this as completed Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValarDragon ValarDragon

Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ValarDragon @cwgoes @QiAnXinCodeSafe