Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(codec/unknownproto): Do not rely on gogo descriptor internals #18540

Closed
testinginprod opened this issue Nov 22, 2023 · 0 comments · Fixed by #18541
Closed

refactor(codec/unknownproto): Do not rely on gogo descriptor internals #18540

testinginprod opened this issue Nov 22, 2023 · 0 comments · Fixed by #18541
Assignees
@testinginprod
Labels
C: Proto Proto definition and proto release

Comments

@testinginprod
Copy link
Contributor

Currently unknown proto implementation relies on gogo generator types, this is not required since we could simply be using the official descriptorpb package. Ref: https://github.com/cosmos/cosmos-sdk/blob/main/codec/unknownproto/unknown_fields.go#L15
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Nov 22, 2023
@testinginprod testinginprod mentioned this issue Nov 22, 2023
Merged
20 tasks
@tac0turtle tac0turtle added C: Proto Proto definition and proto release and removed needs-triage Issue that needs to be triaged labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@testinginprod testinginprod

Labels
C: Proto Proto definition and proto release
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
2 participants
@tac0turtle @testinginprod