Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The /txs/{hash} API should return a 404 if no transaction is found for the given hash #3639

Closed
2 of 4 tasks
luciotudisco opened this issue Feb 13, 2019 · 1 comment
Closed
2 of 4 tasks

The /txs/{hash} API should return a 404 if no transaction is found for the given hash #3639

luciotudisco opened this issue Feb 13, 2019 · 1 comment
Labels
good first issue T:Bug

Comments

@luciotudisco
Copy link

luciotudisco commented Feb 13, 2019 •
edited
Loading

Summary of Bug

The /txs/{hash} API should return a 404 if no transaction is found for the given hash. At the moment the API returns a 500 error.

Note, you already do something similar for /blocks/{height}, for instance.

Steps to Reproduce

  • GET /txs/{hash} where no transaction on chain has the given hash.
  • A 500 response is returned.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jackzampolin jackzampolin changed the title The /txs/{hash} API should return a 404 if no transaction is fund for the given hash The /txs/{hash} API should return a 404 if no transaction is fond for the given hash Feb 13, 2019
@jackzampolin jackzampolin mentioned this issue Feb 13, 2019
Merged
@jackzampolin
Copy link
Member

Thanks for the report @luciotudisco! I've got a PR up to fix this.

@luciotudisco luciotudisco changed the title The /txs/{hash} API should return a 404 if no transaction is fond for the given hash The /txs/{hash} API should return a 404 if no transaction is found for the given hash Feb 14, 2019
@zenit70 zenit70 mentioned this issue Jan 20, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderbez @jackzampolin @luciotudisco