Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references within types/staking.go #3928

Closed
rigelrozanski opened this issue Mar 18, 2019 · 0 comments · Fixed by #4417
Closed

Remove references within types/staking.go #3928

rigelrozanski opened this issue Mar 18, 2019 · 0 comments · Fixed by #4417
Assignees
@fedekunze
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Milestone
v0.36.0

Comments

@rigelrozanski
Copy link
Contributor

Maintenance item, especially relevant for types/staking.go

Many of these interfaces are antiquated and can be moved back to modules using the expected keepers approach... the whole staking/slashing/distribution/governance approach we use is really non-sdk level and ought to be moved back towards /x
@rigelrozanski rigelrozanski added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Mar 18, 2019
@rigelrozanski rigelrozanski mentioned this issue Mar 18, 2019
Closed
@fedekunze fedekunze added this to the v0.35.0 milestone Apr 5, 2019
@fedekunze fedekunze self-assigned this May 23, 2019
@fedekunze fedekunze mentioned this issue May 25, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
v0.36.0
Development

Successfully merging a pull request may close this issue.

R4R: cleanup staking references from types pkg cosmos/cosmos-sdk
2 participants
@rigelrozanski @fedekunze