-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Remove onlyAminoSigners in sequence check (backport #10029) #10034
Merged
robert-zaremba
merged 9 commits into
release/v0.44.x
from
mergify/bp/release/v0.43.x/pr-10029
Sep 1, 2021
Merged
fix!: Remove onlyAminoSigners in sequence check (backport #10029) #10034
robert-zaremba
merged 9 commits into
release/v0.44.x
from
mergify/bp/release/v0.43.x/pr-10029
Sep 1, 2021
Commits on Sep 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d0dfaa1 - Browse repository at this point
Copy the full SHA d0dfaa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f99a04a - Browse repository at this point
Copy the full SHA f99a04aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf6c4c3 - Browse repository at this point
Copy the full SHA cf6c4c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c34f49 - Browse repository at this point
Copy the full SHA 0c34f49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6949a70 - Browse repository at this point
Copy the full SHA 6949a70View commit details -
Configuration menu - View commit details
-
Copy full SHA for be30b24 - Browse repository at this point
Copy the full SHA be30b24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cfa714 - Browse repository at this point
Copy the full SHA 1cfa714View commit details -
fix!: Remove onlyAminoSigners in sequence check (#10029)
## Description Amino multisig update. It breaks the state machine and it's needed for the next SDK upgrade. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 78c3c4e) # Conflicts: # client/tx/legacy.go # client/tx/legacy_test.go
Configuration menu - View commit details
-
Copy full SHA for e1ec537 - Browse repository at this point
Copy the full SHA e1ec537View commit details -
Configuration menu - View commit details
-
Copy full SHA for d944ced - Browse repository at this point
Copy the full SHA d944cedView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.