Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove onlyAminoSigners in sequence check (backport #10029) #10034

Merged
merged 9 commits into from
Sep 1, 2021

Commits on Sep 1, 2021

  1. Configuration menu
    Copy the full SHA
    d0dfaa1 View commit details
    Browse the repository at this point in the history
  2. add changelog

    clevinson committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f99a04a View commit details
    Browse the repository at this point in the history
  3. update changelog

    clevinson committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    cf6c4c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c34f49 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6949a70 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    be30b24 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1cfa714 View commit details
    Browse the repository at this point in the history
  8. fix!: Remove onlyAminoSigners in sequence check (#10029)

    ## Description
    
    Amino multisig update. It breaks the state machine and it's needed for the next SDK upgrade.
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [x] added `!` to the type prefix if API or client breaking change
    - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit 78c3c4e)
    
    # Conflicts:
    #	client/tx/legacy.go
    #	client/tx/legacy_test.go
    robert-zaremba committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e1ec537 View commit details
    Browse the repository at this point in the history
  9. fix conflicts

    robert-zaremba committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    d944ced View commit details
    Browse the repository at this point in the history