feat!: remove legacy REST (backport #9594)

[mergify]

This is an automatic backport of pull request #9594 done by Mergify.
Cherry-pick of cd22168 has failed:

On branch mergify/bp/release/v0.44.x/pr-9594
Your branch is up to date with 'origin/release/v0.44.x'.

You are currently cherry-picking commit cd221680c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client/docs/config.json
	modified:   client/docs/statik/statik.go
	modified:   client/docs/swagger-ui/swagger.yaml
	deleted:    client/docs/swagger_legacy.yaml
	modified:   client/grpc/tmservice/service_test.go
	deleted:    client/rest/rest.go
	modified:   client/rpc/block.go
	deleted:    client/rpc/routes.go
	modified:   client/rpc/rpc_test.go
	modified:   client/rpc/status.go
	modified:   client/rpc/validators.go
	modified:   go.sum
	modified:   server/api/server.go
	modified:   simapp/app.go
	new file:   testutil/rest/rest.go
	modified:   types/module/module_test.go
	modified:   types/query/pagination.go
	deleted:    types/rest/rest.go
	deleted:    types/rest/rest_test.go
	modified:   x/auth/client/cli/tx_multisign.go
	modified:   x/auth/client/cli/tx_sign.go
	deleted:    x/auth/client/rest/query.go
	deleted:    x/auth/client/rest/rest.go
	modified:   x/auth/client/testutil/suite.go
	modified:   x/auth/module.go
	modified:   x/auth/tx/service_test.go
	modified:   x/auth/vesting/module.go
	deleted:    x/authz/client/rest/grpc_query_test.go
	modified:   x/authz/client/testutil/query.go
	modified:   x/authz/client/testutil/tx.go
	modified:   x/authz/module/module.go
	deleted:    x/bank/client/rest/query.go
	deleted:    x/bank/client/rest/rest.go
	deleted:    x/bank/client/rest/tx.go
	renamed:    x/bank/client/rest/grpc_query_test.go -> x/bank/client/testutil/grpc.go
	modified:   x/bank/module.go
	modified:   x/capability/module.go
	modified:   x/crisis/module.go
	modified:   x/distribution/client/proposal_handler.go
	deleted:    x/distribution/client/rest/query.go
	deleted:    x/distribution/client/rest/rest.go
	deleted:    x/distribution/client/rest/tx.go
	deleted:    x/distribution/client/rest/utils.go
	modified:   x/distribution/client/testutil/cli_test.go
	renamed:    x/distribution/client/rest/grpc_query_test.go -> x/distribution/client/testutil/grpc_query_suite.go
	modified:   x/distribution/module.go
	modified:   x/evidence/client/evidence_handler.go
	deleted:    x/evidence/client/rest/query.go
	deleted:    x/evidence/client/rest/rest.go
	deleted:    x/evidence/client/rest/tx.go
	modified:   x/evidence/module.go
	modified:   x/feegrant/module/module.go
	deleted:    x/genutil/client/rest/query.go
	modified:   x/genutil/module.go
	modified:   x/gov/client/proposal_handler.go
	deleted:    x/gov/client/rest/grpc_query_test.go
	deleted:    x/gov/client/rest/query.go
	deleted:    x/gov/client/rest/rest.go
	deleted:    x/gov/client/rest/rest_test.go
	deleted:    x/gov/client/rest/tx.go
	modified:   x/gov/module.go
	deleted:    x/mint/client/rest/grpc_query_test.go
	deleted:    x/mint/client/rest/query.go
	deleted:    x/mint/client/rest/rest.go
	modified:   x/mint/module.go
	modified:   x/params/client/proposal_handler.go
	deleted:    x/params/client/rest/grpc_query_test.go
	deleted:    x/params/client/rest/rest.go
	modified:   x/params/client/utils/utils.go
	modified:   x/params/module.go
	deleted:    x/slashing/client/rest/grpc_query_test.go
	deleted:    x/slashing/client/rest/query.go
	deleted:    x/slashing/client/rest/rest.go
	deleted:    x/slashing/client/rest/tx.go
	modified:   x/slashing/module.go
	deleted:    x/staking/client/rest/grpc_query_test.go
	deleted:    x/staking/client/rest/query.go
	deleted:    x/staking/client/rest/rest.go
	deleted:    x/staking/client/rest/rest_test.go
	deleted:    x/staking/client/rest/tx.go
	deleted:    x/staking/client/rest/utils.go
	modified:   x/staking/client/testutil/suite.go
	modified:   x/staking/module.go
	modified:   x/upgrade/client/proposal_handler.go
	deleted:    x/upgrade/client/rest/query.go
	deleted:    x/upgrade/client/rest/rest.go
	deleted:    x/upgrade/client/rest/tx.go
	modified:   x/upgrade/client/testutil/cli_test.go
	modified:   x/upgrade/module.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   client/tx/tx.go
	both modified:   codec/amino_codec_test.go
	both modified:   x/auth/client/cli/query.go
	deleted by them: x/auth/client/rest/broadcast.go
	deleted by them: x/auth/client/rest/decode.go
	deleted by them: x/auth/client/rest/encode.go
	deleted by them: x/auth/client/rest/rest_test.go
	both modified:   x/authz/client/testutil/grpc.go
	deleted by them: x/bank/client/rest/query_test.go
	deleted by them: x/bank/client/rest/tx_test.go
	both modified:   x/gov/client/testutil/grpc.go
	both modified:   x/mint/client/testutil/grpc.go
	both modified:   x/params/client/testutil/grpc.go
	both modified:   x/slashing/client/testutil/grpc.go
	both modified:   x/staking/client/testutil/grpc.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

[orijbot]

Visit https://dashboard.github.orijtech.com?back=0&pr=10037&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details.

[tac0turtle]

can this be punted to 0.45 since this was meant for that release cycle?

[clevinson]

@marbar3778 This is required for #10034. We could choose to reduce the scope of this backport to only remove legacy broadcast & encode REST endpoints, as those are the endpoints that must be removed in order for #10034 to be merged safely.

Do you think we'd be better off just back porting the removal of broadcast & encode? It was my thought that we might as well remove all, rather than only dropping some, but I could be convinced otherwise.

[clevinson]

Closing this PR. After conversation w/ @zmanian it was decided that for v0.44 we should only drop the legacy REST endpoints that are necessary for #10034 (broadcast & encode)