Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove legacy rest docs #9745

Merged
merged 6 commits into from
Jul 27, 2021
Merged

docs: remove legacy rest docs #9745

merged 6 commits into from
Jul 27, 2021

Conversation

ryanchristo
Copy link
Contributor

@ryanchristo ryanchristo commented Jul 21, 2021

Description

Closes: #9615

In preparation for v0.44 and following #9594, we no longer need to include information about legacy REST endpoints in the documentation. This pull request removes documentation referencing legacy REST endpoints.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review July 21, 2021 22:34
@blushi blushi self-assigned this Jul 23, 2021
@tac0turtle tac0turtle added A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. labels Jul 26, 2021
@orijbot
Copy link

orijbot commented Jul 26, 2021

Visit https://dashboard.github.orijtech.com?pr=9745&repo=cosmos%2Fcosmos-sdk to see benchmark details.

order: 2
-->

# REST Endpoints Migration
Copy link
Contributor

@amaury1093 amaury1093 Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we actually keep this doc for 0.44? Legacy REST is removed in 0.44, so a user who learns about this removal during 0.44 might want to refer to this doc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back with revisions. Let me know if the revisions make sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@clevinson clevinson merged commit 3fa7bd2 into master Jul 27, 2021
@clevinson clevinson deleted the ryan/9615-docs-legacy-rest branch July 27, 2021 02:33
@clevinson
Copy link
Contributor

Thanks @ryanchristo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Legacy REST documentation
6 participants