feat(core): return client identifier in create client response. (#6886)

cosmos · Jul 19, 2024 · aefc31d · aefc31d
1 parent 6330deb
commit aefc31d
Show file tree

Hide file tree

Showing 3 changed files with 103 additions and 53 deletions.
diff --git a/modules/core/02-client/types/tx.pb.go b/modules/core/02-client/types/tx.pb.go
diff --git a/modules/core/keeper/msg_server.go b/modules/core/keeper/msg_server.go
@@ -38,11 +38,12 @@ func (k *Keeper) CreateClient(goCtx context.Context, msg *clienttypes.MsgCreateC
 		return nil, err
 	}
 
-	if _, err = k.ClientKeeper.CreateClient(ctx, clientState.ClientType(), msg.ClientState.Value, msg.ConsensusState.Value); err != nil {
+	clientID, err := k.ClientKeeper.CreateClient(ctx, clientState.ClientType(), msg.ClientState.Value, msg.ConsensusState.Value)
+	if err != nil {
 		return nil, err
 	}
 
-	return &clienttypes.MsgCreateClientResponse{}, nil
+	return &clienttypes.MsgCreateClientResponse{ClientId: clientID}, nil
 }
 
 // UpdateClient defines a rpc handler method for MsgUpdateClient.

diff --git a/proto/ibc/core/client/v1/tx.proto b/proto/ibc/core/client/v1/tx.proto
@@ -52,7 +52,11 @@ message MsgCreateClient {
 }
 
 // MsgCreateClientResponse defines the Msg/CreateClient response type.
-message MsgCreateClientResponse {}
+message MsgCreateClientResponse {
+  option (gogoproto.goproto_getters) = false;
+
+  string client_id = 1;
+}
 
 // MsgUpdateClient defines an sdk.Msg to update a IBC client state using
 // the given client message.