Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misbehaviour GetHeight #148

Closed
3 tasks
colin-axner opened this issue Apr 29, 2021 · 0 comments · Fixed by #166
Closed
3 tasks

Remove misbehaviour GetHeight #148

colin-axner opened this issue Apr 29, 2021 · 0 comments · Fixed by #166
Labels
core needs discussion Issues that need discussion before they can be worked on

Comments

@colin-axner
Copy link
Contributor

Summary

We are removing FrozenHeight as a notion in core IBC, thus the misbehaviour height isn't useful. It isn't clear in all implementations what height represents misbehaviour. Initially, misbehaviour was viewed as existing only for two conflicting headers at the same height. We now know that misbehaviour can occur at two different heights - making it difficult to distinguish which height is the offending header since presumably an attacker could produce an invalid header on either side of a valid header.

Core IBC should never rely on misbehaviour.GetHeight() thus, it should be removed from the misbehaviour interface


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added core needs discussion Issues that need discussion before they can be worked on labels Apr 29, 2021
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
* add new ErrKeyNotFound and handle it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core needs discussion Issues that need discussion before they can be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant