Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make goimports doesn't work #1879

Closed
3 tasks
colin-axner opened this issue Aug 4, 2022 · 1 comment
Closed
3 tasks

make goimports doesn't work #1879

colin-axner opened this issue Aug 4, 2022 · 1 comment

Comments

@colin-axner
Copy link
Contributor

Summary

When goimports fails on CI and I run make goimports locally, if there's an issue I receive the output:

/usr/local/bin/docker run  -v /home/bartleby/work/go/src/github.com/cosmos/ibc-go:/ibc-go --rm  -w "/ibc-go" cytopia/goimports -w -local 'github.com/cosmos/ibc-go' "" &> /dev/null || echo "No changed go files to format"
No changed go files to format

but if I fix the issue I receive

/usr/local/bin/docker run  -v /home/bartleby/work/go/src/github.com/cosmos/ibc-go:/ibc-go --rm  -w "/ibc-go" cytopia/goimports -w -local 'github.com/cosmos/ibc-go' "testing/chain.go" &> /dev/null || echo "No changed go files to format"

Running the command causes no changes in diffs. Should it?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

Closing this issue since we got rid of goimports in #2549.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants