Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit events from keeper instead of rpc handler (Channel Open/Closing) #219

Closed
3 tasks
seantking opened this issue Jun 18, 2021 · 0 comments · Fixed by #220
Closed
3 tasks

Emit events from keeper instead of rpc handler (Channel Open/Closing) #219

seantking opened this issue Jun 18, 2021 · 0 comments · Fixed by #220

Comments

@seantking
Copy link
Contributor

Summary of Bug

At present we are using handlers to emit events for channel opening/closing. See here.

We need to emit these events directly from the keeper so that other modules can invoke the events. Relayers listen for these events to finish handshakes, so it is important that we can trigger this from other modules.

Version

V1.0 beta

Steps to Reproduce

Calling OnChanOpenInit keeper function does not emit an event.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
This was referenced Jun 18, 2021
Merged
Closed
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #219 from CosmWasm/better-msg-json
d0645f3 
Store Message ignores missing permission field from JSON Encoding
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
ci: add more linters (cosmos#219)
fdb596f 
ci: add more linters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/channel open/close events cosmos/ibc-go
1 participant
@seantking