Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit events from keeper rather than msg_server for client/connection #221

Closed
3 tasks
seantking opened this issue Jun 18, 2021 · 1 comment
Closed
3 tasks

Emit events from keeper rather than msg_server for client/connection #221

seantking opened this issue Jun 18, 2021 · 1 comment
Assignees
@seantking

Comments

@seantking
Copy link
Contributor

Summary of Bug

Same issue as #219 but for the client/connection handlers.

We can remove these and emit the events in the keeper + msg_server directly.

Version

v1.00 beta

Steps to Reproduce

When calling the keeper functions directly, we do not emit any events. This is a problem when you need the relayer to listen for events and want to call the IBC keeper functions from other modules.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking self-assigned this Jun 18, 2021
@colin-axner colin-axner added this to the 2.0.0 milestone Jul 7, 2021
@crodriguezvega crodriguezvega modified the milestones: 2.0.0, vNext Sep 17, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #221 from CosmWasm/remove-gaia-legacy
666722a 
Remove gaia legacy
@crodriguezvega crodriguezvega removed this from the Q2-2022-backlog milestone Mar 31, 2022
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jun 3, 2022 •
edited
Loading

@seantking, if I am not mistaken this issue is out of date now, right?

I will close it for now. If am wrong, please reopen it.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
docs: unify entries format in CHANGELOG-PENDING.md (cosmos#221)
2704dda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seantking seantking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crodriguezvega @seantking @colin-axner