Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename proof params to differentiate from proofHeight param #3726

Closed
3 tasks
charleenfei opened this issue Jun 1, 2023 · 3 comments · Fixed by #5599
Closed
3 tasks

rename proof params to differentiate from proofHeight param #3726

charleenfei opened this issue Jun 1, 2023 · 3 comments · Fixed by #5599
Labels
good first issue Good for newcomers needs discussion Issues that need discussion before they can be worked on nice-to-have

Comments

@charleenfei
Copy link
Contributor

Summary of Bug

see this comment.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Jun 1, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Jun 10, 2023
@chandiniv1
Copy link
Contributor

Hi @charleenfei
I would like to work on this, Is this just rename to counterpartyChannelProof or anything else

@charleenfei
Copy link
Contributor Author

hi! i'm not sure this issue is ready to be worked on yet, we need to first have an internal discussion on the correct naming. but when it's ready ill be sure to flag you, thank you!

@charleenfei charleenfei added the needs discussion Issues that need discussion before they can be worked on label Dec 11, 2023
@charleenfei
Copy link
Contributor Author

the initial concept proposed, rename proof params to ie: consensusProof or clientProof instead of proofConsensus clientProof, etc, for readability and also to differentiate from proofHeight

@crodriguezvega crodriguezvega mentioned this issue Jan 14, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers needs discussion Issues that need discussion before they can be worked on nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename proofXyz -> xyzProof cosmos/ibc-go
3 participants
@crodriguezvega @charleenfei @chandiniv1