Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TestChain field LastHeader to LatestCommittedHeader #3971

Closed
3 tasks
colin-axner opened this issue Jun 27, 2023 · 2 comments · Fixed by #5672
Closed
3 tasks

Rename TestChain field LastHeader to LatestCommittedHeader #3971

colin-axner opened this issue Jun 27, 2023 · 2 comments · Fixed by #5672
Assignees
@chandiniv1
Labels
change: api breaking Issues or PRs that break Go API (need to be release in a new major version) good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
Testing package i...

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jun 27, 2023 •
edited
Loading

Summary

Rename TestChain field LastHeader to LatestCommittedHeader

The testing package keeps track of what is currently called the last header and a current header. In reality, these are the latest committed header and the current uncommitted header. I propose we make these fields more explicitly named as reading the testing code can get confusing if you don't have the distinction between committed and uncommitted, otherwise you may think that if the current header is 6, then it's block state is considered committed

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added needs discussion Issues that need discussion before they can be worked on type: code hygiene Clean up code but without changing functionality or interfaces labels Jun 27, 2023
@colin-axner colin-axner mentioned this issue Jun 27, 2023
Closed
3 tasks
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Jun 27, 2023
@colin-axner colin-axner mentioned this issue Aug 9, 2023
Closed
9 tasks
@colin-axner colin-axner added the change: api breaking Issues or PRs that break Go API (need to be release in a new major version) label Nov 7, 2023
@colin-axner colin-axner added help wanted Issues for which we would appreciate help/support from the community good first issue Good for newcomers and removed needs discussion Issues that need discussion before they can be worked on labels Jan 15, 2024
@chandiniv1
Copy link
Contributor

@colin-axner can I work on this issue?

@DimitrisJim
Copy link
Contributor

go for it @chandiniv1!

@chandiniv1 chandiniv1 mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandiniv1 chandiniv1

Labels
change: api breaking Issues or PRs that break Go API (need to be release in a new major version) good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
Testing package improvements
Development

Successfully merging a pull request may close this issue.

rename lastheader to latestcommittedheader chandiniv1/ibc-go
3 participants
@DimitrisJim @colin-axner @chandiniv1