Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return errors instead of panicking in router #41

Open
cwgoes opened this issue Oct 30, 2020 · 3 comments · May be fixed by #6314
Open

Return errors instead of panicking in router #41

cwgoes opened this issue Oct 30, 2020 · 3 comments · May be fixed by #6314
Labels
core icebox Issues that we will not address for the time being type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v10.0.0

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Oct 30, 2020

Instead, panic in the app.
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
@colin-axner colin-axner added type: code hygiene Clean up code but without changing functionality or interfaces core labels Apr 21, 2021
@colin-axner colin-axner mentioned this issue Jul 22, 2021
Closed
3 tasks
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@alpe
Merge pull request #41 from cosmwasm/alex/docker_demo_artifact
877c24d 
Push demo artifact to docker hub
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@gin
Merge PR #41: Add umbrellachain to relayer testnet
f759f44
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jtieri @jackzampolin
Merge PR #41: Fetch bug fixes & bump deps
a27cd74 
* remove trailing space in path name

* bump dep versions to fix vulnerabilities
@crodriguezvega
Copy link
Contributor

So this is about turning the panics in this file into errors that are returned?

@colin-axner
Copy link
Contributor

This applies to all of 05-port, not just the router file in types

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@liamsi
Merge pull request cosmos#41 from lazyledger/ismail/core-types
3a54353 
Add core types: Block, Header, Tx, and other required core data structures
@chandiniv1 chandiniv1 mentioned this issue Dec 13, 2023
Closed
@DimitrisJim DimitrisJim added the icebox Issues that we will not address for the time being label Feb 5, 2024
@DimitrisJim
Copy link
Contributor

Adding icebox for time being, see justification in pr comment by Damian #5401 (comment)

@colin-axner colin-axner linked a pull request May 28, 2024 that will close this issue
Draft
10 tasks
@crodriguezvega crodriguezvega added this to the v10.0.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core icebox Issues that we will not address for the time being type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
v10.0.0
4 participants
@crodriguezvega @DimitrisJim @cwgoes @colin-axner