Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace collections.Contains with slices.Contains in go 1.21 #4204

Closed
2 of 3 tasks
DimitrisJim opened this issue Jul 31, 2023 · 5 comments
Closed
2 of 3 tasks

Replace collections.Contains with slices.Contains in go 1.21 #4204

DimitrisJim opened this issue Jul 31, 2023 · 5 comments
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jul 31, 2023 •
edited
Loading

Summary

With the release of Go 1.21, a new package named slices will be added for generic operations on slices, including Contains. We should be able to remove the collections package we have and use the standard library version instead.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces labels Jul 31, 2023
@charymalloju
Copy link

I will take up the issue.

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Aug 2, 2023 •
edited
Loading

thanks for offering @charymalloju!

We don't strictly follow go's release cycle (i.e, we won't necessarily bump to 1.21 when it releases sometime in August as planned) so it might be some time until you could pick this up.

I can ping here when we do bump and let you know though!

@DimitrisJim DimitrisJim added the icebox Issues that we will not address for the time being label Aug 2, 2023
@DimitrisJim
Copy link
Contributor Author

@charymalloju can start working on this after #4398 is merged

@DimitrisJim DimitrisJim added good first issue Good for newcomers and removed icebox Issues that we will not address for the time being labels Aug 22, 2023
@DimitrisJim
Copy link
Contributor Author

bump @charymalloju, that PR was merged, wanna tackle this?

@damiannolan damiannolan mentioned this issue Sep 4, 2023
Closed
3 tasks
@DimitrisJim
Copy link
Contributor Author

closed by #4685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DimitrisJim @charymalloju