Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: look into randomising values in proposal simulation tests #4595

Closed
charleenfei opened this issue Sep 7, 2023 · 2 comments
Closed

refactor: look into randomising values in proposal simulation tests #4595

charleenfei opened this issue Sep 7, 2023 · 2 comments

Comments

@charleenfei
Copy link
Contributor

regarding comment here:

Should we randomise this value as SDK does?

Originally posted by @crodriguezvega in #4466 (comment)
@charleenfei charleenfei mentioned this issue Sep 7, 2023
Merged
9 tasks
@charleenfei
Copy link
Contributor Author

closing this issue for now as the SDK passes a seed (i.e. 1) to rand.NewSource(), so the values are actually deterministic and not random.

@colin-axner
Copy link
Contributor

colin-axner commented Sep 19, 2023 •
edited
Loading

rand.NewSource(), so the values are actually deterministic and not random.

Is this true? Some of the simulation tests were using hard coded values which nullifies the usage of the random seed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charleenfei @colin-axner