Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow does not fail even if exit code 1 #5190

Closed
3 tasks
anhductn2001 opened this issue Nov 28, 2023 · 0 comments · Fixed by #5356
Closed
3 tasks

Workflow does not fail even if exit code 1 #5190

anhductn2001 opened this issue Nov 28, 2023 · 0 comments · Fixed by #5356
Labels
e2e type: bug Something isn't working as expected

Comments

@anhductn2001
Copy link
Contributor

Summary of Bug

When I ran CI in my dev process found that build_test_matrix flow was not failing even if exit code = 1

More context here

Run echo "matrix=$(go run cmd/build_test_matrix/main.go)" >> $GITHUB_OUTPUT
  echo "matrix=$(go run cmd/build_test_matrix/main.go)" >> $GITHUB_OUTPUT
  shell: /usr/bin/bash -e {0}
  env:
    REGISTRY: ghcr.io
    IMAGE_NAME: ibc-go-simd
    IMAGE_NAME_WASM: ibc-go-wasm-simd
    TEST_ENTRYPOINT: 
    TEST_EXCLUSIONS: TestUpgradeTestSuite,TestGrandpaTestSuite
    TEST_NAME: 
exit status 1

Expected Behaviour

Causes this step to throw an error when the exit code is different from 0

Version

On main branch

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e type: bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants