Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation on UpgradableModule interface functions #5466

Closed
3 tasks
DimitrisJim opened this issue Dec 19, 2023 · 0 comments · Fixed by #5474
Closed
3 tasks

Update documentation on UpgradableModule interface functions #5466

DimitrisJim opened this issue Dec 19, 2023 · 0 comments · Fixed by #5474
Assignees
@chatton
Labels
channel-upgradability Channel upgradability feature

Comments

@DimitrisJim
Copy link
Contributor

Seems a couple of these (Ack/Open/Restore) still have a promise of a TODO as their docu string:

ibc-go/modules/core/05-port/types/module.go

Line 129 in 7445417

// OnChanUpgradeAck TODO

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
channel-upgradability Channel upgradability feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improving docstrings for UpgradableModule interface cosmos/ibc-go
3 participants
@crodriguezvega @chatton @DimitrisJim