Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding CLI for getting incentivized packets on a specific channel #1223

Closed
wants to merge 2 commits into from
Closed

feat: adding CLI for getting incentivized packets on a specific channel #1223

wants to merge 2 commits into from

Conversation

seantking
Copy link
Contributor

@seantking seantking commented Apr 6, 2022 •
edited
Loading

Description

closes: #970

How to test:

1. Setup two chains & create a fee enabled transfer channel. 

simd tx ibc-fee pay-packet-fee transfer channel-0 1 --recv-fee 1000stake --ack-fee 1000stake --timeout-fee 1000stake --from $DEMOWALLET_1 --home ./data/test-1 --keyring-backend test --chain-id test-1 --node tcp://localhost:16657

simd query ibc-fee packets-by-channel transfer channel-0 --home ./data/test-1 --chain-id test-1 --node tcp://localhost:16657

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

crodriguezvega
crodriguezvega approved these changes Apr 7, 2022
View reviewed changes
modules/apps/29-fee/client/cli/query.go Outdated
// GetIncentivizedPacketByChannel returns all of the incentivized packets on a given channel
func GetIncentivizedPacketByChannel() *cobra.Command {
cmd := &cobra.Command{
Use: "packets",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use: "packets",
Use: "packets [port-id] [channel-id] [sequence]",

modules/apps/29-fee/client/cli/query.go Outdated
func GetIncentivizedPacketByChannel() *cobra.Command {
cmd := &cobra.Command{
Use: "packets",
Short: "Query for all of the incentivized packets by channel-id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Short: "Query for all of the incentivized packets by channel-id",
Short: "Query for all the unrelayed incentivized packets on a given channel",

modules/apps/29-fee/client/cli/query.go Outdated
cmd := &cobra.Command{
Use: "packets",
Short: "Query for all of the incentivized packets by channel-id",
Long: "Query for all of the incentivized packets by channel-id. These are packets that have not yet been relayed.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Long: "Query for all of the incentivized packets by channel-id. These are packets that have not yet been relayed.",
Long: "Query for all the unrelayed incentivized packets on a given channel",

@seantking
Copy link
Contributor Author

Changelog needed

@seantking seantking closed this Apr 7, 2022
@seantking seantking deleted the sean/issue#970-cli-incentivized-packets branch August 3, 2022 13:59
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
@dependabot
build(deps): Bump github.com/rs/cors from 1.10.0 to 1.10.1 (cosmos#1223)
90695d2 
Bumps [github.com/rs/cors](https://github.com/rs/cors) from 1.10.0 to
1.10.1.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/rs/cors/commit/e19471c92b1cebff496744b37742991babf3d592"><code>e19471c</code></a>
Prevent empty Access-Control-Expose-Headers header (<a
href="https://redirect.github.com/rs/cors/issues/160">#160</a>)</li>
<li><a
href="https://github.com/rs/cors/commit/20a76bd635d3c8a7ea58f49fad54b8eecb95aa46"><code>20a76bd</code></a>
Update benchmark</li>
<li>See full diff in <a
href="https://github.com/rs/cors/compare/v1.10.0...v1.10.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/rs/cors&package-manager=go_modules&previous-version=1.10.0&new-version=1.10.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@charleenfei charleenfei Awaiting requested review from charleenfei

@damiannolan damiannolan Awaiting requested review from damiannolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seantking @crodriguezvega