Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fumpt carlos upgrade branch #1439

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 26, 2022

  • fumpting carlos sdk 46 tendermint 35 branch to make reviews of Notional's sdk 46 work easier

Description

This is an ergonomics PR that fumpts carlos sdk 46 branch currently in use on gaia, so that we can spare gaia and her dev team the pain of the middleware refactor.

Intended use:

Merge this <- it fumpts carlos' branch so that it is closer to main
Merge beta-2 pr 1412 <- it updates carlos' branch to be compatible with latest ibc-go and sdk 46 beta 2
Merge sdk-master pr 1413 <- it brings carlos' branch up to date with latest cosmos sdk


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant