Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Type(), Route(), GetSignBytes() (removed from sdk.Msg interface) #161

Merged
merged 3 commits into from
May 10, 2021

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented May 7, 2021

Description

SDK has removed Type() Route() and GetSignBytes() from the Msg interface. Those functions are still needed for the transfer message which supports amino signing. They would be unused for all other message types.

I figure we might as well remove what we can before 1.0.0 since after that we would need to wait for a major version release to remove old APIs

closes: #159


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner changed the title remove Type(), Route(), GetSignBytes() (removed from Msg interface upstream) remove Type(), Route(), GetSignBytes() (removed from sdk.Msg interface) May 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #161 (4084225) into main (6537f24) will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   78.48%   78.97%   +0.48%     
==========================================
  Files         109      109              
  Lines        6488     6434      -54     
==========================================
- Hits         5092     5081      -11     
+ Misses       1038      995      -43     
  Partials      358      358              
Impacted Files Coverage Δ
modules/core/02-client/types/msgs.go 76.64% <ø> (+6.17%) ⬆️
modules/core/03-connection/types/msgs.go 85.81% <ø> (+4.11%) ⬆️
modules/core/04-channel/types/msgs.go 77.02% <ø> (+6.07%) ⬆️
modules/core/keeper/msg_server.go 64.89% <100.00%> (ø)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-axner colin-axner merged commit 07d8747 into main May 10, 2021
@colin-axner colin-axner deleted the colin/159-remove-old-funcs branch May 10, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Type(), Route(), GetSignBytes()
4 participants