Commits on Oct 5, 2022

1. fix: partial revert of #1942 (#2148) …

   ## Description
   
   See cosmos/interchain-accounts-demo#129
   
   Adding mock module account in chain setup was assuming that the `NewTestChain` func was using a SimApp() which custom apps do not. Proper way to fund mock module at chain startup for us would be via modifying the default genesis (though we would need to modify the existing SetupChainWithGenesis to not assume the default auth/bank genesis is empty.
   
   I decided to take the easier route of just fixing the one test case using the mock module balance
   
   closes: #XXXX
   
   ---
   
   Before we can merge this PR, please make sure that all the following items have been
   checked off. If any of the checklist items are not applicable, please leave them but
   write a little note why.
   
   - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
   - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
   - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
   - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
   - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
   - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
   - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
   - [ ] Re-reviewed `Files changed` in the Github PR explorer
   - [ ] Review `Codecov Report` in the comment section below once CI passes
   
   (cherry picked from commit 2d3e55d)

   

   colin-axner authored and mergify[bot] committed Oct 5, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 81b3028
   • Browse repository at this point

   Copy the full SHA

   81b3028 View commit details

   Browse the repository at this point in the history