fix: incorrect test case #4014
Merged
fix: incorrect test case #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Jul 5, 2023
Comment on lines
+169
to
+172
| // update client state latest height | ||
| clientState := path.EndpointA.GetClientState() | ||
| clientState.(*ibctm.ClientState).LatestHeight = height5 | ||
| path.EndpointA.SetClientState(clientState) |
There was a problem hiding this comment.
this is the main fix
colin-axner
requested review from
crodriguezvega,
chatton,
DimitrisJim and
charleenfei
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test case referenced breaks in the update to Eden. The issue is that the latest consensus state set is at height 5, but the client state is never updated to this value. In the below check, it enters the wrong if condition because the duplicate update header is > than the client state height (even though it should not be). I believe because of how the test case is wired on main, it happens to be that the client state height == duplicate height. It'd probably fail if you changed 3 to 4
required for #3883
I also took the liberty of using the helper funcs in the testing pkg
ref: #4013
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.