Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move 07-tendermint client state testing to use light client module entry points #6074

Merged
merged 22 commits into from
Apr 11, 2024
Merged

test: move 07-tendermint client state testing to use light client module entry points #6074

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
84c4470
move tests from client state to lcm, use lcm entry point
charleenfei Apr 2, 2024
001b8e1
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 2, 2024
2e8d7db
linter
charleenfei Apr 2, 2024
903d4d6
update Initialise test + coverage
charleenfei Apr 2, 2024
a1f831c
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 2, 2024
d500532
linter
charleenfei Apr 2, 2024
ac8271d
Merge branch 'charly/issue#6001-move-client-state-testing-to-light-cl…
charleenfei Apr 2, 2024
edf7a68
import naming
charleenfei Apr 2, 2024
c197b77
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 3, 2024
82f61d4
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 8, 2024
cad7be3
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 8, 2024
4ee5664
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 9, 2024
6a0a755
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 9, 2024
f3d5764
update for pr review
charleenfei Apr 9, 2024
779971e
Merge branch 'charly/issue#6001-move-client-state-testing-to-light-cl…
charleenfei Apr 9, 2024
37bd55a
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 9, 2024
0bdd7f9
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 10, 2024
f3c0123
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 10, 2024
1c2acde
update for pr review
charleenfei Apr 10, 2024
3919b60
Merge branch 'charly/issue#6001-move-client-state-testing-to-light-cl…
charleenfei Apr 10, 2024
1f86c8a
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 10, 2024
0e84b58
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/light-clients/07-tendermint/client_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (cs ClientState) Validate() error {
}

if err := light.ValidateTrustLevel(cs.TrustLevel.ToTendermint()); err != nil {
return err
return errorsmod.Wrapf(ErrInvalidTrustLevel, "%s", err)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this error wrapping for debugging ux

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, but I think in other places we do something just like...

Suggested change
return errorsmod.Wrapf(ErrInvalidTrustLevel, "%s", err)
return errorsmod.Wrap(ErrInvalidTrustLevel, err.Error())

}
if cs.TrustingPeriod <= 0 {
return errorsmod.Wrap(ErrInvalidTrustingPeriod, "trusting period must be greater than zero")
Expand Down Expand Up @@ -303,7 +303,6 @@ func verifyDelayPeriodPassed(ctx sdk.Context, store storetypes.KVStore, proofHei
return errorsmod.Wrapf(ErrDelayPeriodNotPassed, "cannot verify packet until time: %d, current time: %d",
validTime, currentTimestamp)
}

}

if delayBlockPeriod != 0 {
Expand Down
Loading
Loading