fix!: improve message validation #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Testing
MSalopek
approved these changes
Nov 30, 2023
sainoe
reviewed
Nov 30, 2023
| return errorsmod.Wrap(ErrInvalidPacketData, "validator fields cannot be empty") | ||
| func (vdt SlashPacketData) Validate() error { | ||
| // vdt.Validator.Address must be a consensus address | ||
| if err := sdk.VerifyAddressFormat(vdt.Validator.Address); err != nil { |
There was a problem hiding this comment.
Suggested change
| if err := sdk.VerifyAddressFormat(vdt.Validator.Address); err != nil { | |
| if err := sdk.ConsAddressFromBech32(string(vdt.Validator.Address)); err != nil { |
There was a problem hiding this comment.
Sorry, the updated suggestion should work!
Forget the suggestion.
sainoe
reviewed
Nov 30, 2023
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
sainoe
approved these changes
Dec 1, 2023
2 tasks
2 tasks
MSalopek
pushed a commit
that referenced
this pull request
Dec 1, 2023
* validate ValidatorSetChangePacketData * update ValidateBasic for ValidatorSetChangePacketData * update ConsumerPacketData validation * fix TestConsumerPacketSendExpiredClient * update TestOnRecvSlashPacketErrors * fix TestQueueAndSendSlashPacket * remove TODO * nit: validate MsgAssignConsumerKey * add changelog entries * fix linter * fix gosec * rename ValidateBasic to Validate (IBC packets) * Update x/ccv/types/wire.go Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> * revert SlashPacketData address validation --------- Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1370, #634
OnRecvPacketkeeper methods to return an error instead of an IBC ack.EDIT: validation of
MsgSubmitConsumerDoubleVotingwill be added in a following PRAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)CHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change