Comments and better panic prints for e2e tests #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
commented
Jan 11, 2023
| providerToReturn, ok := provider.App.(T) | ||
| if !ok { | ||
| panic(fmt.Sprintf("provider app type returned from app initer does not match app type passed in as type param: %T, %T", | ||
| provider.App, *new(T))) |
There was a problem hiding this comment.
shaspitz
changed the title
shaspitz
changed the title
shaspitz
requested review from
jtremback,
mpoke,
sainoe and
danwt
as code owners
mpoke
approved these changes
Jan 12, 2023
3 tasks
shaspitz
requested review from
mmulji-ic,
glnro and
yaruwangway
as code owners
MSalopek
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds comments and panic prints for issues similar to duality-labs/duality#281. This will allow consumer chain devs to more easily know about an issue with e2e tests running against their consumer implementation.
Type of change
Refactor: Changes existing code style, naming, structure, etc.Regression tests
E2e tests still pass
New behavior tests
n/a