fix StopConsumerChain not running in cachedContext #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
requested review from
jtremback,
mpoke,
sainoe,
shaspitz,
mmulji-ic,
glnro and
yaruwangway
as code owners
yaruwangway
reviewed
Mar 24, 2023
glnro
reviewed
Mar 24, 2023
glnro
approved these changes
Mar 24, 2023
MSalopek
added a commit
that referenced
this pull request
Mar 24, 2023
* fix StopConsumerChain not running in cachedContext * start hermes in docker tests * fix some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a bug in
StopConsumerChain.A bug was identified in ICS provider code where the StopConsumerChain is not actually called in a cachedContext. Instead, it is run in the global app context.
This meant that the consumer chain can get removed unexpectedly and its CCV chanel was closed as soon as the proposal tx gets handled.
This bug is resolved i
Linked issues
Closes: #799
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Feature: Changes and/or adds code behavior, irrelevant to bug fixesFix: Changes and/or adds code behavior, specifically to fix a bugRefactor: Changes existing code style, naming, structure, etc.Testing: Adds testingDocs: Adds documentationRegression tests
New behavior tests
Expanded existing tests to confirm that the consumer is not removed prematurely and also that it is cleanly removed when a proposal passes.
Versioning Implications
If the above box is checked, which version should be bumped?
MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)PATCH: Non consensus breaking changesTargeting
Please select one of the following:
v1.1.0