testing: e2e tests for soft opt out #857
Conversation
shaspitz
requested review from
jtremback,
mpoke,
sainoe,
MSalopek,
mmulji-ic,
glnro and
yaruwangway
as code owners
|
@mpoke lets chat tomorrow about whether this PR validates that the default value of |
I don't think it does. IIUC, both the consumer and provider in the tests are running the same version of ICS, the one where the provider sets the |
|
@mpoke |
| // soft opt-out threshold to 0.05 in the consumer genesis to ensure that the | ||
| // consumer binary doesn't panic. Sdk requires that all params are set to valid | ||
| // values from the genesis file. | ||
| genesisChanges: ".app_state.ccvconsumer.params.soft_opt_out_threshold = \"0.05\"", |
There was a problem hiding this comment.
No biggie, but couldn't this be 0?
There was a problem hiding this comment.
0 is a valid value for that param, but setting it to 0 would make the test fail (just confirmed) and wouldn't validate the feature. It'd essentially mean 0% of validator set is allowed to opt out
Description
Adds e2e tests validating #765
Linked issues
Closes #849
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Feature: Changes and/or adds code behavior, irrelevant to bug fixesFix: Changes and/or adds code behavior, specifically to fix a bugRefactor: Changes existing code style, naming, structure, etc.Testing: Adds testingDocs: Adds documentationRegression tests
Existing happy path steps are still there
New behavior tests
Two new steps functions were added, stepsRedelegateForOptOut and stepsDowntimeWithOptOut.
Versioning Implications
If the above box is checked, which version should be bumped?
MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)PATCH: Non consensus breaking changesTargeting
Please select one of the following: