Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer needs to support disabled timeout heights #481

Closed
colin-axner opened this issue Mar 29, 2021 · 1 comment
Closed

Relayer needs to support disabled timeout heights #481

colin-axner opened this issue Mar 29, 2021 · 1 comment

Comments

@colin-axner
Copy link
Contributor

Packets can disable usage of a timeout height by setting the revision number and height both to 0.

The relayer was never architected to support revision numbers. The revision number feature was added fairly last minute to IBC. A lot of places assume the existence of a timeout height. State based relaying needs to obtain the timeout in the revision form when parsing past txs, instead of only parsing the revision height and assuming the revision number based on chain-id

Alternatively, a quicker fix is to add a check if the timeout height is 0 and set the revision number to 0 as well

I'm not sure if relaying based on streaming accounts for this.

@seantking
Copy link
Contributor

seantking commented Mar 29, 2021

Setting both height & revision number to 0 causes the relayer to error for me.

timeoutHeight := clienttypes.Height{
    RevisionNumber: 0,
    RevisionHeight: 0,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants