-
Notifications
You must be signed in to change notification settings - Fork 69
/
solvable_orders.rs
1412 lines (1289 loc) · 49 KB
/
solvable_orders.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
use {
crate::{
boundary::{self, SolvableOrders},
domain::{self, auction::Price, eth},
infra::{self, banned},
},
anyhow::{Context, Result},
bigdecimal::BigDecimal,
chrono::{DateTime, Utc},
database::order_events::OrderEventLabel,
ethrpc::block_stream::CurrentBlockWatcher,
futures::future::join_all,
indexmap::IndexSet,
itertools::{Either, Itertools},
model::{
order::{Order, OrderClass, OrderUid},
signature::Signature,
time::now_in_epoch_seconds,
},
number::conversions::u256_to_big_decimal,
primitive_types::{H160, H256, U256},
prometheus::{
Histogram,
HistogramTimer,
HistogramVec,
IntCounter,
IntCounterVec,
IntGauge,
IntGaugeVec,
},
shared::{
account_balances::{BalanceFetching, Query},
bad_token::BadTokenDetecting,
price_estimation::{
native::NativePriceEstimating,
native_price_cache::CachingNativePriceEstimator,
},
remaining_amounts,
signature_validator::{SignatureCheck, SignatureValidating},
},
std::{
collections::{btree_map::Entry, BTreeMap, HashMap, HashSet},
sync::{Arc, Weak},
time::Duration,
},
strum::VariantNames,
tokio::{sync::Mutex, time::Instant},
tracing::Instrument,
};
#[derive(prometheus_metric_storage::MetricStorage)]
pub struct Metrics {
/// Tracks success and failure of the solvable orders cache update task.
#[metric(labels("result"))]
auction_update: IntCounterVec,
/// Time taken to update the solvable orders cache.
#[metric(buckets(0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12))]
auction_update_total_time: Histogram,
/// Time spent on auction update individual stage.
#[metric(labels("stage"))]
auction_update_stage_time: HistogramVec,
/// Auction creations.
auction_creations: IntCounter,
/// Auction candidate orders grouped by class.
#[metric(labels("class"))]
auction_candidate_orders: IntGaugeVec,
/// Auction solvable orders grouped by class.
#[metric(labels("class"))]
auction_solvable_orders: IntGaugeVec,
/// Auction filtered orders grouped by class.
#[metric(labels("reason"))]
auction_filtered_orders: IntGaugeVec,
/// Auction filtered market orders due to missing native token price.
auction_market_order_missing_price: IntGauge,
}
/// Keeps track and updates the set of currently solvable orders.
/// For this we also need to keep track of user sell token balances for open
/// orders so this is retrievable as well.
/// The cache is updated in the background whenever a new block appears or when
/// the cache is explicitly notified that it should update for example because a
/// new order got added to the order book.
pub struct SolvableOrdersCache {
min_order_validity_period: Duration,
persistence: infra::Persistence,
banned_users: banned::Users,
balance_fetcher: Arc<dyn BalanceFetching>,
bad_token_detector: Arc<dyn BadTokenDetecting>,
cache: Mutex<Option<Inner>>,
native_price_estimator: Arc<CachingNativePriceEstimator>,
signature_validator: Arc<dyn SignatureValidating>,
metrics: &'static Metrics,
weth: H160,
limit_order_price_factor: BigDecimal,
protocol_fees: domain::ProtocolFees,
cow_amm_registry: cow_amm::Registry,
}
type Balances = HashMap<Query, U256>;
struct Inner {
auction: domain::Auction,
solvable_orders: boundary::SolvableOrders,
last_order_creation_timestamp: DateTime<Utc>,
}
impl SolvableOrdersCache {
#[allow(clippy::too_many_arguments)]
pub fn new(
min_order_validity_period: Duration,
persistence: infra::Persistence,
banned_users: banned::Users,
balance_fetcher: Arc<dyn BalanceFetching>,
bad_token_detector: Arc<dyn BadTokenDetecting>,
native_price_estimator: Arc<CachingNativePriceEstimator>,
signature_validator: Arc<dyn SignatureValidating>,
weth: H160,
limit_order_price_factor: BigDecimal,
protocol_fees: domain::ProtocolFees,
cow_amm_registry: cow_amm::Registry,
) -> Arc<Self> {
let self_ = Arc::new(Self {
min_order_validity_period,
persistence,
banned_users,
balance_fetcher,
bad_token_detector,
cache: Mutex::new(None),
native_price_estimator,
signature_validator,
metrics: Metrics::instance(observe::metrics::get_storage_registry()).unwrap(),
weth,
limit_order_price_factor,
protocol_fees,
cow_amm_registry,
});
self_
}
/// Spawns a task that periodically updates the set of open orders
/// and builds a new auction with them.
pub fn spawn_background_task(
cache: &Arc<Self>,
block_stream: CurrentBlockWatcher,
update_interval: Duration,
) {
tokio::task::spawn(
update_task(Arc::downgrade(cache), update_interval, block_stream)
.instrument(tracing::info_span!("solvable_orders_cache")),
);
}
pub async fn current_auction(&self) -> Option<domain::Auction> {
self.cache
.lock()
.await
.as_ref()
.map(|inner| inner.auction.clone())
}
/// Manually update solvable orders. Usually called by the background
/// updating task.
///
/// Usually this method is called from update_task. If it isn't, which is
/// the case in unit tests, then concurrent calls might overwrite each
/// other's results.
pub async fn update(&self, block: u64) -> Result<()> {
let start = Instant::now();
let (db_solvable_orders, latest_creation_timestamp) = self.get_solvable_orders().await?;
let orders = db_solvable_orders
.orders
.values()
.cloned()
.collect::<Vec<_>>();
let mut counter = OrderFilterCounter::new(self.metrics, &orders);
let mut invalid_order_uids = HashSet::new();
let mut filtered_order_events = Vec::new();
let (balances, orders, cow_amms) = {
let queries = orders.iter().map(Query::from_order).collect::<Vec<_>>();
let cow_amms_fut = async {
let _timer = self.stage_timer("cow_amm_registry");
self.cow_amm_registry.amms().await
};
tokio::join!(
self.fetch_balances(queries),
self.filter_invalid_orders(orders, &mut counter, &mut invalid_order_uids,),
cow_amms_fut
)
};
let orders = orders_with_balance(orders, &balances);
let removed = counter.checkpoint("insufficient_balance", &orders);
invalid_order_uids.extend(removed);
let orders = filter_dust_orders(orders, &balances);
let removed = counter.checkpoint("dust_order", &orders);
filtered_order_events.extend(removed);
// create auction
let (orders, mut prices) =
get_orders_with_native_prices(orders, &self.native_price_estimator, self.metrics);
// Add WETH price if it's not already there to support ETH wrap when required.
if let Entry::Vacant(entry) = prices.entry(self.weth) {
let _timer = self.stage_timer("weth_price_fetch");
let weth_price = self
.native_price_estimator
.estimate_native_price(self.weth)
.await
.expect("weth price fetching can never fail");
let weth_price = to_normalized_price(weth_price)
.expect("weth price can never be outside of U256 range");
entry.insert(weth_price);
}
let cow_amm_tokens = cow_amms
.iter()
.flat_map(|cow_amm| cow_amm.traded_tokens())
.unique()
.filter(|token| !prices.contains_key(token))
.cloned()
.collect::<Vec<_>>();
let cow_amm_prices =
get_native_prices(cow_amm_tokens.as_slice(), &self.native_price_estimator);
prices.extend(cow_amm_prices);
let removed = counter.checkpoint("missing_price", &orders);
filtered_order_events.extend(removed);
let orders = filter_mispriced_limit_orders(orders, &prices, &self.limit_order_price_factor);
let removed = counter.checkpoint("out_of_market", &orders);
filtered_order_events.extend(removed);
let removed = counter.record(&orders);
filtered_order_events.extend(removed);
// spawning a background task since `order_events` table insert operation takes
// a while and the result is ignored.
self.persistence.store_order_events(
invalid_order_uids
.iter()
.map(|id| domain::OrderUid(id.0))
.collect(),
OrderEventLabel::Invalid,
);
self.persistence.store_order_events(
filtered_order_events
.iter()
.map(|id| domain::OrderUid(id.0))
.collect(),
OrderEventLabel::Filtered,
);
let surplus_capturing_jit_order_owners = cow_amms
.iter()
.filter(|cow_amm| {
cow_amm.traded_tokens().iter().all(|token| {
let price_exist = prices.contains_key(token);
if !price_exist {
tracing::debug!(
cow_amm = ?cow_amm.address(),
?token,
"omitted from auction due to missing prices"
);
}
price_exist
})
})
.map(|cow_amm| cow_amm.address())
.cloned()
.map(eth::Address::from)
.collect::<Vec<_>>();
let auction = domain::Auction {
block,
latest_settlement_block: db_solvable_orders.latest_settlement_block,
orders: orders
.into_iter()
.map(|order| {
let quote = db_solvable_orders
.quotes
.get(&order.metadata.uid.into())
.cloned();
self.protocol_fees
.apply(order, quote, &surplus_capturing_jit_order_owners)
})
.collect(),
prices: prices
.into_iter()
.map(|(key, value)| {
Price::new(value.into()).map(|price| (eth::TokenAddress(key), price))
})
.collect::<Result<_, _>>()?,
surplus_capturing_jit_order_owners,
};
*self.cache.lock().await = Some(Inner {
auction,
solvable_orders: db_solvable_orders,
last_order_creation_timestamp: latest_creation_timestamp,
});
tracing::debug!(%block, "updated current auction cache");
self.metrics
.auction_update_total_time
.observe(start.elapsed().as_secs_f64());
Ok(())
}
async fn fetch_balances(&self, queries: Vec<Query>) -> HashMap<Query, U256> {
let fetched_balances = {
let _timer = self.stage_timer("balance_fetch");
self.balance_fetcher.get_balances(&queries).await
};
queries
.into_iter()
.zip(fetched_balances)
.filter_map(|(query, balance)| match balance {
Ok(balance) => Some((query, balance)),
Err(err) => {
tracing::warn!(
owner = ?query.owner,
token = ?query.token,
source = ?query.source,
error = ?err,
"failed to get balance"
);
None
}
})
.collect()
}
/// Returns current solvable orders along with the latest order creation
/// timestamp.
async fn get_solvable_orders(&self) -> Result<(SolvableOrders, DateTime<Utc>)> {
const INITIAL_ORDER_CREATION_TIMESTAMP: DateTime<Utc> = DateTime::<Utc>::MIN_UTC;
// A new auction should be created regardless of whether new solvable orders are
// found. The incremental solvable orders cache updater should only be
// enabled after the initial full SQL query
// (`persistence::all_solvable_orders`) returned some orders. Until then,
// `MIN_UTC` is used to indicate that no orders have been found yet by
// (`persistence::all_solvable_orders`). This prevents situations where
// starting the service with a large existing DB would cause
// the incremental query to load all unfiltered orders into memory, potentially
// leading to OOM issues because incremental query doesn't filter out
// expired/invalid orders in the SQL query and basically can return the whole
// table when filters with default values are used.
let (db_solvable_orders, previous_creation_timestamp) = {
let cache_data = {
let lock = self.cache.lock().await;
match &*lock {
Some(cache)
if cache.last_order_creation_timestamp
> INITIAL_ORDER_CREATION_TIMESTAMP =>
{
Some((
cache.solvable_orders.orders.clone(),
cache.last_order_creation_timestamp,
cache.solvable_orders.latest_settlement_block,
))
}
_ => None,
}
};
let min_valid_to = now_in_epoch_seconds()
+ u32::try_from(self.min_order_validity_period.as_secs())
.context("min_order_validity_period is not u32")?;
match cache_data {
Some((current_orders, last_order_creation_timestamp, latest_settlement_block)) => (
self.persistence
.solvable_orders_after(
current_orders,
last_order_creation_timestamp,
latest_settlement_block,
min_valid_to,
)
.await?,
last_order_creation_timestamp,
),
None => (
self.persistence.all_solvable_orders(min_valid_to).await?,
INITIAL_ORDER_CREATION_TIMESTAMP,
),
}
};
let latest_creation_timestamp = db_solvable_orders
.orders
.values()
.map(|order| order.metadata.creation_date)
.max()
.map_or(previous_creation_timestamp, |max_creation_timestamp| {
std::cmp::max(max_creation_timestamp, previous_creation_timestamp)
});
Ok((db_solvable_orders, latest_creation_timestamp))
}
/// Executed orders filtering in parallel.
async fn filter_invalid_orders(
&self,
mut orders: Vec<Order>,
counter: &mut OrderFilterCounter,
invalid_order_uids: &mut HashSet<OrderUid>,
) -> Vec<Order> {
let banned_user_orders_fut = async {
let _timer = self.stage_timer("banned_user_filtering");
find_banned_user_orders(&orders, &self.banned_users).await
};
let invalid_signature_orders_fut = async {
let _timer = self.stage_timer("invalid_signature_filtering");
find_invalid_signature_orders(&orders, self.signature_validator.as_ref()).await
};
let unsupported_token_orders_fut = async {
let _timer = self.stage_timer("unsupported_token_filtering");
find_unsupported_tokens(&orders, self.bad_token_detector.clone()).await
};
let (banned_user_orders, invalid_signature_orders, unsupported_token_orders) = tokio::join!(
banned_user_orders_fut,
invalid_signature_orders_fut,
unsupported_token_orders_fut,
);
counter.checkpoint_by_invalid_orders("banned_user", &banned_user_orders);
counter.checkpoint_by_invalid_orders("invalid_signature", &invalid_signature_orders);
counter.checkpoint_by_invalid_orders("unsupported_token", &unsupported_token_orders);
invalid_order_uids.extend(banned_user_orders);
invalid_order_uids.extend(invalid_signature_orders);
invalid_order_uids.extend(unsupported_token_orders);
orders.retain(|order| !invalid_order_uids.contains(&order.metadata.uid));
orders
}
pub fn track_auction_update(&self, result: &str) {
self.metrics
.auction_update
.with_label_values(&[result])
.inc();
}
fn stage_timer(&self, stage: &str) -> HistogramTimer {
self.metrics
.auction_update_stage_time
.with_label_values(&[stage])
.start_timer()
}
}
/// Finds all orders whose owners or receivers are in the set of "banned"
/// users.
async fn find_banned_user_orders(orders: &[Order], banned_users: &banned::Users) -> Vec<OrderUid> {
let banned = banned_users
.banned(
orders
.iter()
.flat_map(|order| std::iter::once(order.metadata.owner).chain(order.data.receiver)),
)
.await;
orders
.iter()
.filter_map(|order| {
std::iter::once(&order.metadata.owner)
.chain(&order.data.receiver)
.any(|addr| banned.contains(addr))
.then_some(order.metadata.uid)
})
.collect()
}
fn get_native_prices(
tokens: &[H160],
native_price_estimator: &CachingNativePriceEstimator,
) -> HashMap<H160, U256> {
native_price_estimator
.get_cached_prices(tokens)
.into_iter()
.flat_map(|(token, result)| {
let price = to_normalized_price(result.ok()?)?;
Some((token, price))
})
.collect()
}
/// Finds unsigned PreSign and EIP-1271 orders whose signatures are no longer
/// validating.
async fn find_invalid_signature_orders(
orders: &[Order],
signature_validator: &dyn SignatureValidating,
) -> Vec<OrderUid> {
let (mut invalid_orders, orders): (Vec<_>, Vec<_>) = orders.iter().partition_map(|order| {
if matches!(
order.metadata.status,
model::order::OrderStatus::PresignaturePending
) {
Either::Left(order.metadata.uid)
} else {
Either::Right(order)
}
});
let checks = orders
.iter()
.filter_map(|order| match &order.signature {
Signature::Eip1271(signature) => {
let (H256(hash), signer, _) = order.metadata.uid.parts();
Some(SignatureCheck {
signer,
hash,
signature: signature.clone(),
interactions: order.interactions.pre.clone(),
})
}
_ => None,
})
.collect::<Vec<_>>();
if checks.is_empty() {
return invalid_orders;
}
let mut validations = signature_validator
.validate_signatures(checks)
.await
.into_iter();
for order in orders {
if !matches!(&order.signature, Signature::Eip1271(_)) {
continue;
}
if let Err(err) = validations.next().unwrap() {
tracing::warn!(
order =% order.metadata.uid, ?err,
"invalid EIP-1271 signature"
);
invalid_orders.push(order.metadata.uid)
}
}
invalid_orders
}
/// Removes orders that can't possibly be settled because there isn't enough
/// balance.
fn orders_with_balance(mut orders: Vec<Order>, balances: &Balances) -> Vec<Order> {
// Prefer newer orders over older ones.
orders.sort_by_key(|order| std::cmp::Reverse(order.metadata.creation_date));
orders.retain(|order| {
let balance = match balances.get(&Query::from_order(order)) {
None => return false,
Some(balance) => *balance,
};
if order.data.partially_fillable && balance >= 1.into() {
return true;
}
let needed_balance = match order.data.sell_amount.checked_add(order.data.fee_amount) {
None => return false,
Some(balance) => balance,
};
balance >= needed_balance
});
orders
}
/// Filters out dust orders i.e. partially fillable orders that, when scaled
/// have a 0 buy or sell amount.
fn filter_dust_orders(mut orders: Vec<Order>, balances: &Balances) -> Vec<Order> {
orders.retain(|order| {
if !order.data.partially_fillable {
return true;
}
let balance = if let Some(balance) = balances.get(&Query::from_order(order)) {
*balance
} else {
return false;
};
let Ok(remaining) =
remaining_amounts::Remaining::from_order_with_balance(&order.into(), balance)
else {
return false;
};
let (Ok(sell_amount), Ok(buy_amount)) = (
remaining.remaining(order.data.sell_amount),
remaining.remaining(order.data.buy_amount),
) else {
return false;
};
!sell_amount.is_zero() && !buy_amount.is_zero()
});
orders
}
/// Keep updating the cache every N seconds or when an update notification
/// happens. Exits when this becomes the only reference to the cache.
async fn update_task(
cache: Weak<SolvableOrdersCache>,
update_interval: Duration,
current_block: CurrentBlockWatcher,
) {
loop {
// We are not updating on block changes because
// - the state of orders could change even when the block does not like when an
// order gets cancelled off chain
// - the event updater takes some time to run and if we go first we would not
// update the orders with the most recent events.
let start = Instant::now();
let cache = match cache.upgrade() {
Some(self_) => self_,
None => {
tracing::debug!("exiting solvable orders update task");
break;
}
};
let block = current_block.borrow().number;
match cache.update(block).await {
Ok(()) => {
cache.track_auction_update("success");
tracing::debug!(
%block,
"updated solvable orders in {}s",
start.elapsed().as_secs_f32()
)
}
Err(err) => {
cache.track_auction_update("failure");
tracing::warn!(
?err,
%block,
"failed to update solvable orders in {}s",
start.elapsed().as_secs_f32()
)
}
}
tokio::time::sleep_until(start + update_interval).await;
}
}
fn get_orders_with_native_prices(
orders: Vec<Order>,
native_price_estimator: &CachingNativePriceEstimator,
metrics: &Metrics,
) -> (Vec<Order>, BTreeMap<H160, U256>) {
let traded_tokens = orders
.iter()
.flat_map(|order| [order.data.sell_token, order.data.buy_token])
.collect::<HashSet<_>>()
.into_iter()
.collect::<Vec<_>>();
let prices = get_native_prices(&traded_tokens, native_price_estimator);
// Filter both orders and prices so that we only return orders that have prices
// and prices that have orders.
let mut filtered_market_orders = 0_i64;
let mut used_prices = BTreeMap::new();
let (usable, filtered): (Vec<_>, Vec<_>) = orders.into_iter().partition(|order| {
let (t0, t1) = (&order.data.sell_token, &order.data.buy_token);
match (prices.get(t0), prices.get(t1)) {
(Some(p0), Some(p1)) => {
used_prices.insert(*t0, *p0);
used_prices.insert(*t1, *p1);
true
}
_ => {
filtered_market_orders += i64::from(order.metadata.class == OrderClass::Market);
false
}
}
});
let tokens_by_priority = prioritize_missing_prices(filtered);
native_price_estimator.replace_high_priority(tokens_by_priority);
// Record separate metrics just for missing native token prices for market
// orders, as they should be prioritized.
metrics
.auction_market_order_missing_price
.set(filtered_market_orders);
(usable, used_prices)
}
/// Computes which missing native prices are the most urgent to fetch.
/// Prices for recent orders have the highest priority because those are most
/// likely market orders which users expect to get settled ASAP.
/// For the remaining orders we prioritize token prices that are needed the most
/// often. That way we have the chance to make a majority of orders solvable
/// with very few fetch requests.
fn prioritize_missing_prices(mut orders: Vec<Order>) -> IndexSet<H160> {
/// How old an order can be at most to be considered a market order.
const MARKET_ORDER_AGE_MINUTES: i64 = 30;
let market_order_age = chrono::Duration::minutes(MARKET_ORDER_AGE_MINUTES);
let now = chrono::Utc::now();
// newer orders at the start
orders.sort_by_key(|o| std::cmp::Reverse(o.metadata.creation_date));
let mut high_priority_tokens = IndexSet::new();
let mut most_used_tokens = HashMap::<H160, usize>::new();
for order in orders {
let sell_token = order.data.sell_token;
let buy_token = order.data.buy_token;
let is_market = now.signed_duration_since(order.metadata.creation_date) <= market_order_age;
if is_market {
// already correct priority because orders were sorted by creation_date
high_priority_tokens.extend([sell_token, buy_token]);
} else {
// count how often tokens are used to prioritize popular tokens
*most_used_tokens.entry(sell_token).or_default() += 1;
*most_used_tokens.entry(buy_token).or_default() += 1;
}
}
// popular tokens at the start
let most_used_tokens = most_used_tokens
.into_iter()
.sorted_by_key(|entry| std::cmp::Reverse(entry.1))
.map(|(token, _)| token);
high_priority_tokens.extend(most_used_tokens);
high_priority_tokens
}
fn to_normalized_price(price: f64) -> Option<U256> {
let uint_max = 2.0_f64.powi(256);
let price_in_eth = 1e18 * price;
if price_in_eth.is_normal() && price_in_eth >= 1. && price_in_eth < uint_max {
Some(U256::from_f64_lossy(price_in_eth))
} else {
None
}
}
async fn find_unsupported_tokens(
orders: &[Order],
bad_token: Arc<dyn BadTokenDetecting>,
) -> Vec<OrderUid> {
let bad_tokens = join_all(
orders
.iter()
.flat_map(|o| o.data.token_pair().into_iter().flatten())
.unique()
.map(|token| {
let bad_token = bad_token.clone();
async move {
match bad_token.detect(token).await {
Ok(quality) => (!quality.is_good()).then_some(token),
Err(err) => {
tracing::warn!(?token, ?err, "unable to determine token quality");
Some(token)
}
}
}
}),
)
.await
.into_iter()
.flatten()
.collect::<HashSet<_>>();
orders
.iter()
.filter_map(|order| {
order
.data
.token_pair()
.into_iter()
.flatten()
.any(|token| bad_tokens.contains(&token))
.then_some(order.metadata.uid)
})
.collect()
}
/// Filter out limit orders which are far enough outside the estimated native
/// token price.
fn filter_mispriced_limit_orders(
mut orders: Vec<Order>,
prices: &BTreeMap<H160, U256>,
price_factor: &BigDecimal,
) -> Vec<Order> {
orders.retain(|order| {
if !order.is_limit_order() {
return true;
}
let sell_price = *prices.get(&order.data.sell_token).unwrap();
let buy_price = *prices.get(&order.data.buy_token).unwrap();
// Convert the sell and buy price to the native token (ETH) and make sure that
// sell is higher than buy with the configurable price factor.
let (sell_native, buy_native) = match (
order.data.sell_amount.checked_mul(sell_price),
order.data.buy_amount.checked_mul(buy_price),
) {
(Some(sell), Some(buy)) => (sell, buy),
_ => {
tracing::warn!(
order_uid = %order.metadata.uid,
"limit order overflow computing native amounts",
);
return false;
}
};
let sell_native = u256_to_big_decimal(&sell_native);
let buy_native = u256_to_big_decimal(&buy_native);
sell_native >= buy_native * price_factor
});
orders
}
/// Order filtering state for recording filtered orders over the course of
/// building an auction.
struct OrderFilterCounter {
metrics: &'static Metrics,
/// Mapping of remaining order UIDs to their classes.
orders: HashMap<OrderUid, OrderClass>,
/// Running tally for counts of filtered orders.
counts: HashMap<Reason, usize>,
}
type Reason = &'static str;
impl OrderFilterCounter {
fn new(metrics: &'static Metrics, orders: &[Order]) -> Self {
// Eagerly store the candidate orders. This ensures that that gauge is
// always up to date even if there are errors in the auction building
// process.
let initial_counts = orders
.iter()
.counts_by(|order| order.metadata.class.as_ref());
for class in OrderClass::VARIANTS {
let count = initial_counts.get(class).copied().unwrap_or_default();
metrics
.auction_candidate_orders
.with_label_values(&[class])
.set(i64::try_from(count).unwrap_or(i64::MAX));
}
Self {
metrics,
orders: orders
.iter()
.map(|order| (order.metadata.uid, order.metadata.class))
.collect(),
counts: HashMap::new(),
}
}
/// Creates a new checkpoint from the current remaining orders.
fn checkpoint(&mut self, reason: Reason, orders: &[Order]) -> Vec<OrderUid> {
let filtered_orders = orders
.iter()
.fold(self.orders.clone(), |mut order_uids, order| {
order_uids.remove(&order.metadata.uid);
order_uids
});
*self.counts.entry(reason).or_default() += filtered_orders.len();
for order_uid in filtered_orders.keys() {
self.orders.remove(order_uid).unwrap();
}
if !filtered_orders.is_empty() {
tracing::debug!(
%reason,
count = filtered_orders.len(),
orders = ?filtered_orders, "filtered orders"
);
}
filtered_orders.into_keys().collect()
}
/// Creates a new checkpoint based on the found invalid orders.
fn checkpoint_by_invalid_orders(&mut self, reason: Reason, invalid_orders: &[OrderUid]) {
if invalid_orders.is_empty() {
return;
}
let mut counter = 0;
for order_uid in invalid_orders {
if self.orders.remove(order_uid).is_some() {
counter += 1;
}
}
*self.counts.entry(reason).or_default() += counter;
if counter > 0 {
tracing::debug!(
%reason,
count = invalid_orders.len(),
orders = ?invalid_orders, "filtered orders"
);
}
}
/// Records the filter counter to metrics.
/// If there are orders that have been filtered out since the last
/// checkpoint these orders will get recorded with the readon "other".
/// Returns these catch-all orders.
fn record(mut self, orders: &[Order]) -> Vec<OrderUid> {
let removed = self.checkpoint("other", orders);
self.metrics.auction_creations.inc();
let remaining_counts = self.orders.iter().counts_by(|(_, class)| class.as_ref());
for class in OrderClass::VARIANTS {
let count = remaining_counts.get(class).copied().unwrap_or_default();
self.metrics
.auction_solvable_orders
.with_label_values(&[class])
.set(i64::try_from(count).unwrap_or(i64::MAX));
}
for (reason, count) in self.counts {
self.metrics
.auction_filtered_orders
.with_label_values(&[reason])
.set(i64::try_from(count).unwrap_or(i64::MAX));
}
removed
}
}
#[cfg(test)]
mod tests {
use {
super::*,
futures::FutureExt,
maplit::{btreemap, hashset},
mockall::predicate::eq,
model::{
interaction::InteractionData,
order::{Interactions, OrderBuilder, OrderData, OrderMetadata, OrderUid},
},
primitive_types::H160,
shared::{
bad_token::list_based::ListBasedDetector,
price_estimation::{native::MockNativePriceEstimating, PriceEstimationError},
signature_validator::{MockSignatureValidating, SignatureValidationError},
},
};
#[test]
fn computes_u256_prices_normalized_to_1e18() {
assert_eq!(
to_normalized_price(0.5).unwrap(),
U256::from(500_000_000_000_000_000_u128),
);
}
#[test]
fn normalize_prices_fail_when_outside_valid_input_range() {
assert!(to_normalized_price(0.).is_none());
assert!(to_normalized_price(-1.).is_none());
assert!(to_normalized_price(f64::INFINITY).is_none());
let min_price = 1. / 1e18;
assert!(to_normalized_price(min_price).is_some());
assert!(to_normalized_price(min_price * (1. - f64::EPSILON)).is_none());
let uint_max = 2.0_f64.powi(256);
let max_price = uint_max / 1e18;
assert!(to_normalized_price(max_price).is_none());
assert!(to_normalized_price(max_price * (1. - f64::EPSILON)).is_some());
}
#[tokio::test]
async fn filters_tokens_without_native_prices() {
let token1 = H160([1; 20]);
let token2 = H160([2; 20]);
let token3 = H160([3; 20]);
let token4 = H160([4; 20]);
let orders = vec![
OrderBuilder::default()
.with_sell_token(token1)
.with_buy_token(token2)
.with_buy_amount(1.into())