Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBCluster unable to update values with MasterUserPassword error #1807

Closed
dhumphries-sainsburys opened this issue Jul 17, 2023 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@dhumphries-sainsburys
Copy link
Contributor

dhumphries-sainsburys commented Jul 17, 2023

What happened?

Can successfully deploy DBCluster using the below with no problems

kind: DBCluster
metadata:
  name: example-aurora-postgres-cluster
spec:
  forProvider:
    region: eu-west-1
    engine: aurora-postgresql
    engineVersion: '13.6'
    allowMajorVersionUpgrade: true
    backupRetentionPeriod: 14
    copyTagsToSnapshot: true
    masterUsername: masteruser
    manageMasterUserPassword: false
    port: 5432
    autogeneratePassword: true
    autoMinorVersionUpgrade: false
    masterUserPasswordSecretRef:
      name: example-aurora-mysql-cluster
      namespace: crossplane-system
      key: password
    storageEncrypted: true
    databaseName: auroradb
    dbClusterParameterGroupName: example-clusterparametergroup13
    dbSubnetGroupName: lab-data
    skipFinalSnapshot: true
    applyImmediately: true
    finalDBSnapshotIdentifier: test-dan-humphries-lab-aurora-dantest-psql-final
    vpcSecurityGroupIDRefs:
      - name: 'lab-rds-sg'
  providerConfigRef:
    name: aws
  providerRef:
    name: aws
  writeConnectionSecretToRef:
    name: test-dan-humphries-rds-dantest-psql-auroracluster
    namespace: flux-system

If i try to update the fields though it returns the below.

update failed: cannot update DBCluster in AWS: InvalidParameterCombination: MasterUserPassword must be provided when ManageMasterUserPassword is set to false.\n\tstatus code: 400, request id:

The fields i have seen issues with so far are dbClusterParameterGroupName & engineVersion both of which would stop us being able to upgrade clusters.

The error makes little sense considering we have an autogenerated password anyways and the field it is complaining about doesn't exist in the spec. Also testing this against a cluster where we provide the password as per the example CRs but that gets the same

How can we reproduce it?

Create the example above and try and change one of the mentioned fields such as putting engineVersion to 13.7

What environment did it happen in?

Crossplane version: v1.12.1
AWS Provider version: v0.40.0
EKS version: 1.25.11

@dhumphries-sainsburys dhumphries-sainsburys added the bug Something isn't working label Jul 17, 2023
@MisterMX
Copy link
Collaborator

This might be solved by #1756?

@dhumphries-sainsburys
Copy link
Contributor Author

Potentially. It seems to be in the same kind of area so might solve this as a side effect but guess we will see when that change gets merged

@MisterMX
Copy link
Collaborator

MisterMX commented Aug 4, 2023

@dhumphries-sainsburys can you check whether your problem is solved in v0.42.0?

@dhumphries-sainsburys
Copy link
Contributor Author

Can confirm this is fixed in v0.42.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants