From 99b6667b896a59b054419001c12cf91519b8ad11 Mon Sep 17 00:00:00 2001 From: Lovro Sviben <46844730+lsviben@users.noreply.github.com> Date: Wed, 2 Aug 2023 16:17:01 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Pete Lumbis --- .../guides/import-existing-resources.md | 13 ++++++------- content/master/concepts/managed-resources.md | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/content/knowledge-base/guides/import-existing-resources.md b/content/knowledge-base/guides/import-existing-resources.md index d4aec9b06..fd79ad1a8 100644 --- a/content/knowledge-base/guides/import-existing-resources.md +++ b/content/knowledge-base/guides/import-existing-resources.md @@ -85,22 +85,21 @@ managed resource `spec` changes the external resource. ## Import resources automatically -Automatically import external resources with the granular management polices -[`spec.managementPolicies: ["Observe"]`]({{}}). +Automatically import external resources with an `Observe` [management policy]({{}}). -Crossplane imports `Observe` only resources but never changes or deletes the +Crossplane imports observe only resources but never changes or deletes the resources. {{}} The managed resource `managementPolicies` option is an alpha feature. -Enable the `managementPolicies` in a provider with `--enable-management-policies` +Enable `managementPolicies` in a provider with `--enable-management-policies` in a [ControllerConfig]({{}}). {{< /hint >}} -### Apply the ["Observe"] managementPolicies +### Apply the Observe management policy Create a new managed resource matching the @@ -233,10 +232,10 @@ status: ## Control imported ObserveOnly resources -Crossplane can take active control of `ObserveOnly` imported resources by +Crossplane can take active control of observe only imported resources by changing the `managementPolicies` after import. -Change the {{}}managementPolicy{{}} field +Change the {{}}managementPolicies{{}} field of the managed resource to {{}}["*"]{{}}. diff --git a/content/master/concepts/managed-resources.md b/content/master/concepts/managed-resources.md index 34c504de5..616919b66 100644 --- a/content/master/concepts/managed-resources.md +++ b/content/master/concepts/managed-resources.md @@ -229,7 +229,7 @@ that if the field is already filled, the controller won't override its value. {{}} The managed resource `managementPolicies` option is an alpha feature. -Enable the `managementPolicies` in a provider with `--enable-management-policies` +Enable `managementPolicies` in a provider with `--enable-management-policies` in a [ControllerConfig]({{}}). {{< /hint >}}