Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "Import resources automatically" after Support Granular management policies #497

Closed
haarchri opened this issue Jul 24, 2023 · 3 comments · Fixed by #510
Closed

update "Import resources automatically" after Support Granular management policies #497

haarchri opened this issue Jul 24, 2023 · 3 comments · Fixed by #510
Assignees

Comments

@haarchri
Copy link
Contributor

haarchri commented Jul 24, 2023

What's Missing?

after we merging the following PRs we need to update the documentation

The old
spec.managmentPolicy: FullControl/ObserveOnly/OrphanOnDelete
is getting replaced by
spec.managementPolicies:["*", "Observe", "Create", "Update", "LateInitialize", "Delete"]

crossplane/upjet#224
crossplane-contrib/provider-upjet-aws#785
crossplane-contrib/provider-upjet-gcp#336
crossplane-contrib/provider-upjet-azure#495

@haarchri
Copy link
Contributor Author

@lsviben
Copy link
Contributor

lsviben commented Jul 24, 2023

I'm contemplating whether it's necessary to clarify whether we should drop the old design document or not...

https://github.com/crossplane/crossplane/blob/master/design/design-doc-observe-only-resources.md vs. https://github.com/crossplane/crossplane/blob/master/design/one-pager-ignore-changes.md#deletion-policy

Can we use the Status field? ObserveOnly -> Deprecated, IgnoreChanges -> Approved/Implemented/Accepted?

@plumbis
Copy link
Collaborator

plumbis commented Jul 24, 2023

@haarchri are there changes to Crossplane to support these new statuses? Is this something entirely in the scope of providers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants