Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Custom resource definitions #5

Open
taharah opened this issue Sep 13, 2019 · 2 comments
Open

[QUESTION] Custom resource definitions #5

taharah opened this issue Sep 13, 2019 · 2 comments
Labels
question Further information is requested

Comments

@taharah
Copy link

taharah commented Sep 13, 2019

How would you reference a proto definition for a CRD?

@cxuu cxuu added the question Further information is requested label Sep 13, 2019
@cxuu
Copy link
Contributor

cxuu commented Sep 13, 2019

If I recall correctly, Kubernetes API does not support Protobuf representation for custom resources at the moment, which is the primary motivation for Isopod to support kube.put_yaml() in addition to kube.put() https://github.com/cruise-automation/isopod#kubeput_yaml.

If you are asking for validation of custom resource objects in a way similar to standard types, then you need to register it here https://github.com/cruise-automation/isopod/blob/master/pkg/kube/scheme.go. And yes, we are thinking about replacing this hard dependency with runtime plugin. Feel free to reach out to @dilyevsky if you are interested.

@taharah
Copy link
Author

taharah commented Sep 13, 2019

Yes, I was mainly interested in how to get type validation for CRDs. The work to make the existing schema loading more dynamic may tie into #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

2 participants