Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Metadata and JVM ID computation can block threads #1106

Closed
andrewazores opened this issue Oct 7, 2022 · 0 comments · Fixed by #1105
Closed

[Task] Metadata and JVM ID computation can block threads #1106

andrewazores opened this issue Oct 7, 2022 · 0 comments · Fixed by #1105
Assignees
Labels
bug Something isn't working high-priority

Comments

@andrewazores
Copy link
Member

andrewazores commented Oct 7, 2022

For example, try simply defining a custom target like fake:9091, where fake is not a resolvable hostname. This should succeed very quickly because all that needs to be done is inserting a small update to the discovery database. However, this also triggers a target discovery event internally and notifies the metadata manager of the change, which then uses the notifying thread (in this case, an HTTP webserver thread that is processing the custom target request) to perform some work around checking if metadata is fresh, which also requires connecting to that new target definition to compute its hash ID and check the list of active recordings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant