Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryostat should be deployed in h2:file mode #451

Closed
andrewazores opened this issue Sep 13, 2022 · 2 comments · Fixed by #474
Closed

Cryostat should be deployed in h2:file mode #451

andrewazores opened this issue Sep 13, 2022 · 2 comments · Fixed by #474
Assignees
Labels
feat New feature or request good first issue Good for newcomers high-priority

Comments

@andrewazores
Copy link
Member

These two environment variables should be set for the Cryostat container:

https://github.com/cryostatio/cryostat/blob/58bc83dd1e0145bf34cd3289f908a929ef664d6a/smoketest.sh#L22

If not set then the container defaults to running in h2:mem mode, which does not provide an actual persistent database. The discovery API would be not durable across reboots, which also means custom target definitions would not survive.

@andrewazores andrewazores added feat New feature or request good first issue Good for newcomers high-priority labels Sep 13, 2022
@tthvo tthvo self-assigned this Sep 22, 2022
@tthvo
Copy link
Member

tthvo commented Sep 22, 2022

What if we allow customization for this behaviour? Maybe a spec field to set which type of storage to use?

Also, just wondering how postgres is etup our deployment on k8s/OCP context :D

@andrewazores
Copy link
Member Author

Yea, eventually we should make it configurable. Right now the change is too fresh and likely to change heavily for the next release too so I don't want to try to support a Postgres setup in the official distribution just yet.

I guess if the Cryostat CR has no storage allocated (no PVC), then the Operator could automatically configure Cryostat to use h2:mem. If there is a PVC then use h2:file with the file located somewhere on that PVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request good first issue Good for newcomers high-priority
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants