-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: sdk v0.46.11 is not used #909
Problem: sdk v0.46.11 is not used #909
Conversation
Solution: - update sdk/tendermint/ethermint dependencies - patch cometbft-db to use grocksdb - still need to replace tm-db because of indirect dependencies
Signed-off-by: yihuang <huang@crypto.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only date format need update
Co-authored-by: mmsqe <tqd0800210105@gmail.com> Signed-off-by: yihuang <huang@crypto.com>
yeah, fixed, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking Cosmos SDK v0.46.11 CHANGELOG
https://github.com/cosmos/cosmos-sdk/blob/v0.46.11/CHANGELOG.md
Want to check if this store change is potentially breaking or not?
cosmos/cosmos-sdk#14410
should be non-breaking, we had the uneven case in some nodes before, which eventually manifested as app-hash mismatch, but not in the chain itself. in the future those cases (if ever happens again) will be revealed ealier. |
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)