Add support for transfer #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuturu-tech
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Thanks for the PR! Using a low-level call might be better in case the property failure relies on something being executed in the fallback function (Echidna doesn't currently support receive crytic/echidna#714).
I think we can merge this as a partial patch for Echidna after changing to low-level call and updating the template string. I'll create an issue so we can later add support for msg.data for the fallback and the same for Medusa
Open
3 tasks
tuturu-tech
approved these changes
Feb 6, 2024
|
Refactored the PR to use low-level call instead and added a test to ensure the generated file can be compiled and that the property fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no function name, we can make a ether transfer instead. Right now it uses
.transfer, but we could use low level call instead?In addition this PR add a general
except Exceptionto prevent the tool from crashing on incorrect parsing