Add support for Python 3.12 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably makes sense to add Python 3.12 here https://github.com/csachs/pyproject-flake8/blob/main/.github/workflows/test.yml#L10 |
Python 3.12 configparser removed SafeConfigParser. python/cpython#89336 (comment) leading to this issue ``` Traceback (most recent call last): File "/home/user/.cache/pypoetry/virtualenvs/chapter-marker-bSlZRqHo-py3.12/bin/pflake8", line 5, in <module> from pflake8.__main__ import main File "/home/user/.cache/pypoetry/virtualenvs/chapter-marker-bSlZRqHo-py3.12/lib/python3.12/site-packages/pflake8/__init__.py", line 54, in <module> class DivertingSafeConfigParser(ConfigParserTomlMixin, configparser.SafeConfigParser): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser' ```
fliiiix
force-pushed
the
bugfix/python312-support
branch
from
44bf22c
to
9107658
Compare
|
@csachs, could you please look at this pull request? |
|
This is blocking testing on python 3.12 for us any chance of getting this merged and a new release @csachs? |
|
Friendly nudge @csachs :) |
|
Please excuse the delay, thanks for the PR. |
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12 configparser removed SafeConfigParser.
python/cpython#89336 (comment)
leading to this issue