From b27ac1b64bf8dde33fccb67421c9264335adc981 Mon Sep 17 00:00:00 2001
From: John Dorlus <silne.dorlus@elastic.co>
Date: Thu, 6 May 2021 12:59:59 -0400
Subject: [PATCH] Changed Upgrade Assistant test to reflect hiding the UI
 (#96714)

* Added test to verify the UI changes for hiding the app.

* Running tests on repeat.

* Tests passed. Removing only clause to allow full suite to run.

* Skipping firefox.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
---
 .../upgrade_assistant/upgrade_assistant.ts    | 29 ++++++++++++++-----
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts b/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
index f5df83e780a7ab..e6ad6c1fe05675 100644
--- a/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
+++ b/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
@@ -16,21 +16,34 @@ export default function upgradeAssistantFunctionalTests({
   const PageObjects = getPageObjects(['upgradeAssistant', 'common']);
   const log = getService('log');
   const retry = getService('retry');
+  const testSubjects = getService('testSubjects');
+
+  // Updated for the hiding of the UA UI.
+  describe('Upgrade Checkup', function () {
+    this.tags('skipFirefox');
+
+    before(async () => {
+      await esArchiver.load('empty_kibana');
+      await security.testUser.setRoles(['global_upgrade_assistant_role']);
+    });
 
-  // Failing: See https://github.com/elastic/kibana/issues/86546
-  describe.skip('Upgrade Checkup', function () {
-    this.tags('includeFirefox');
-    before(async () => await esArchiver.load('empty_kibana'));
     after(async () => {
       await PageObjects.upgradeAssistant.waitForTelemetryHidden();
       await esArchiver.unload('empty_kibana');
     });
 
-    it('allows user to navigate to upgrade checkup', async () => {
+    it('Overview page', async () => {
+      await PageObjects.upgradeAssistant.navigateToPage();
+      await retry.waitFor('Upgrade Assistant overview page to be visible', async () => {
+        return testSubjects.exists('comingSoonPrompt');
+      });
+    });
+
+    it.skip('allows user to navigate to upgrade checkup', async () => {
       await PageObjects.upgradeAssistant.navigateToPage();
     });
 
-    it('allows user to toggle deprecation logging', async () => {
+    it.skip('allows user to toggle deprecation logging', async () => {
       log.debug('expect initial state to be ON');
       expect(await PageObjects.upgradeAssistant.deprecationLoggingEnabledLabel()).to.be('On');
       expect(await PageObjects.upgradeAssistant.isDeprecationLoggingEnabled()).to.be(true);
@@ -53,7 +66,7 @@ export default function upgradeAssistantFunctionalTests({
       });
     });
 
-    it('allows user to open cluster tab', async () => {
+    it.skip('allows user to open cluster tab', async () => {
       await PageObjects.upgradeAssistant.navigateToPage();
       await PageObjects.upgradeAssistant.clickTab('cluster');
       expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(
@@ -61,7 +74,7 @@ export default function upgradeAssistantFunctionalTests({
       );
     });
 
-    it('allows user to open indices tab', async () => {
+    it.skip('allows user to open indices tab', async () => {
       await PageObjects.upgradeAssistant.navigateToPage();
       await PageObjects.upgradeAssistant.clickTab('indices');
       expect(await PageObjects.upgradeAssistant.issueSummaryText()).to.be(