Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all APYs into a single value #142

Open
bout3fiddy opened this issue Apr 11, 2024 · 5 comments · Fixed by #154
Open

Combine all APYs into a single value #142

bout3fiddy opened this issue Apr 11, 2024 · 5 comments · Fixed by #154
Assignees
Labels
enhancement New feature or request

Comments

@bout3fiddy
Copy link

A suggestion from a prolific user was to combine all APYs into a single number, such that a user simply needs to do a hover over the number to get a full breakdown of the yield sources.

An example from Balancer:

Image

This also allows us to reduce the number of columns by 1.

The fe should then show a min and max value, with a breakdown of of the min being base + unboosted incentives, and max being base + boosted incentives.

@bout3fiddy bout3fiddy added the enhancement New feature or request label Apr 11, 2024
@amytsang
Copy link
Collaborator

Image
To do this ticket:

  1. We need to switch Lend APY to Lend APR or switch Rewards APR to Rewards APY (Probably Rewards need to be switched to APY)?
  2. Combine different assets into 1. Also asset type will disappear unless hover.

End result will look like something like this:
Table cell header: Total APR | APY
Table row content: <min-percent> - <max-percent> <Tooltip>

Tooltip:
Lend APR|APY: <number>%
CRV: <number>% CRV
Incentives: <number>% <token>

Please address these two comments and once ready, we can move this ticket to unblock

@bout3fiddy
Copy link
Author

tagging @michwill to weigh in here.

@bout3fiddy
Copy link
Author

Discussed and:

  1. switch to APR, and on hover you can show apr|apy for lend.
  2. also fine.

proposed tooltip looks fine:

Lend APR (APY): <number>% (<number>%)
CRV APR: <number>% CRV
Incentives APR: <number>% <token>

@michwill
Copy link

I think yes, we switch to APR here

@michwill
Copy link

We need to switch Lend APY to Lend APR or switch Rewards APR to Rewards APY (Probably Rewards need to be switched to APY)?

Let's do APR

Combine different assets into 1. Also asset type will disappear unless hover.

That's fine on desktop view. On mobile view, since there's no hover, can probably do line 12% (7% lend + 5% CRV)

@amytsang amytsang linked a pull request Apr 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants